<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:itoral@igalia.com" title="Iago Toral <itoral@igalia.com>"> <span class="fn">Iago Toral</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - valgrind errors in glsl-fs-uniform-array-loop-unroll.shader_test; random code generation"
href="https://bugs.freedesktop.org/show_bug.cgi?id=79202">bug 79202</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - valgrind errors in glsl-fs-uniform-array-loop-unroll.shader_test; random code generation"
href="https://bugs.freedesktop.org/show_bug.cgi?id=79202#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - valgrind errors in glsl-fs-uniform-array-loop-unroll.shader_test; random code generation"
href="https://bugs.freedesktop.org/show_bug.cgi?id=79202">bug 79202</a>
from <span class="vcard"><a class="email" href="mailto:itoral@igalia.com" title="Iago Toral <itoral@igalia.com>"> <span class="fn">Iago Toral</span></a>
</span></b>
<pre>Fixed with:
commit 6ac1bc90c4a7a6f32901a9782e14b090f6fe5270
Author: Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>>
Date: Tue Mar 10 11:36:43 2015 +0100
i965: Fix out-of-bounds accesses into pull_constant_loc array
The piglit test glsl-fs-uniform-array-loop-unroll.shader_test was designed
to do an out of bounds access into an uniform array to make sure that we
handle that situation gracefully inside the driver, however, as Ken
describes
in <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - valgrind errors in glsl-fs-uniform-array-loop-unroll.shader_test; random code generation"
href="show_bug.cgi?id=79202">bug 79202</a>, Valgrind reports that this is leading to an out-of-bounds
access
in fs_visitor::demote_pull_constants().
Before accessing the pull_constant_loc array we should make sure that
the uniform we are trying to access is valid.
Bugzilla: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - valgrind errors in glsl-fs-uniform-array-loop-unroll.shader_test; random code generation"
href="show_bug.cgi?id=79202">https://bugs.freedesktop.org/show_bug.cgi?id=79202</a>
Reviewed-by: Matt Turner <<a href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>