<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:itoral@igalia.com" title="Iago Toral <itoral@igalia.com>"> <span class="fn">Iago Toral</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement SSBOs in GLSL front-end and i965"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89597">bug 89597</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>krh@bitplanet.net
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement SSBOs in GLSL front-end and i965"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89597#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement SSBOs in GLSL front-end and i965"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89597">bug 89597</a>
from <span class="vcard"><a class="email" href="mailto:itoral@igalia.com" title="Iago Toral <itoral@igalia.com>"> <span class="fn">Iago Toral</span></a>
</span></b>
<pre>Kristian, the prototype patch you attached defines a ir_binop_ssbo_store
operator for ir_expressions. I have a quick implementation of the ssbo write as
an expression operator that looks like this in GLSL IR:
(declare (temporary ) vec4 ssbo_write_temp)
(assign (zw) (var_ref ssbo_write_temp) (constant vec2 (-3.000000 -4.000000))
)
(expression vec4 ssbo_store (constant uint (0)) (constant uint (0)) (var_ref
ssbo_write_temp) )
(I made it a triop because besides the block number and offset we also need the
value to write. In fact, it would have to end up being quadop because we also
need a write mask operand to know which channels we need to write).
In the beginning I found odd to implement ssbo_store as an expression operator,
mostly because it is not expected to return any value. In fact, I expected that
it would be killed by dead code elimination passes because of this reason. It
seems that I was wrong and this is working fine, but I am not aware of other
expression operators that work like this (I mean, which are not used as part of
a RHS in an assignment), so I wonder if this is how you envisioned the
implementation or if you think that we should implement the ssbo write
differently (maybe having a separate ir_ssbo_store IR node).
What do you think?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>