<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement a NIR -> vec4 pass"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89580#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement a NIR -> vec4 pass"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89580">bug 89580</a>
from <span class="vcard"><a class="email" href="mailto:jason@jlekstrand.net" title="Jason Ekstrand <jason@jlekstrand.net>"> <span class="fn">Jason Ekstrand</span></a>
</span></b>
<pre>(In reply to Eduardo Lima Mitev from <a href="show_bug.cgi?id=89580#c6">comment #6</a>)
<span class="quote">> (In reply to Jason Ekstrand from <a href="show_bug.cgi?id=89580#c5">comment #5</a>)
> > 1) There are two places so far, brw_type_for_nir_type and
> > brw_conditional_for_nir_comparison, where we would like to put things in a
> > common place. Recently, I added a brw_nir.h file and I believe Ken added a
> > brw_nir.c file which would be a perfect place to put those. In fact, we
> > could probably simplify some of the current FS NIR code with your
> > conditionals function.
> >
>
> Yes, it is a good idea and will leave our code less cluttered. However, I
> will turn brw_nir.c to c++ to add these methods. Any caveat with that?</span >
That's ok if we have a good reason for it. However, neither of those functions
does anything that requires C++ so I don't see any good reason to change it
either. They just use #defines that are defined in brw_defines.h and brw_reg.h
both of which are C friendly.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>