<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [hsw bisected][PATCH] atomic counters doesn't work for a binding point different to zero" href="https://bugs.freedesktop.org/show_bug.cgi?id=90175#c1">Comment # 1</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [hsw bisected][PATCH] atomic counters doesn't work for a binding point different to zero" href="https://bugs.freedesktop.org/show_bug.cgi?id=90175">bug 90175</a> from <a class="email" href="mailto:apinheiro@igalia.com" title="Alejandro Piñeiro (freenode IRC: apinheiro) <apinheiro@igalia.com>"> Alejandro Piñeiro (freenode IRC: apinheiro)</a> <pre>Created <a href="attachment.cgi?id=115326" name="attach_115326" title="Fixes the bug">attachment 115326</a> <a href="attachment.cgi?id=115326&action=edit" title="Fixes the bug">[details]</a> <a href='page.cgi?id=splinter.html&bug=90175&attachment=115326'>[review]</a> Fixes the bug Taking into account the explanation on the header about the variable binding (ast.h:553) /** * Binding specified via GL_ARB_shading_language_420pack's "binding" keyword. * * \note * This field is only valid if \c explicit_binding is set. */ int binding; The binding is correct (and should be updated) if explicit_binding is true. But the correct behaviour was updating it if it was false. This was not detected by piglit because all the calls to glBindBufferBase(GL_ATOMIC_COUNTER_BUFFER are using 0. I tested this patch by running all piglit on my system, and I didn't detect regression. I also runned make check without issues.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>