<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - [SNB+ Bisected]Ogles3conform ES3-CTS.shaders.struct.uniform.sampler_array_fragment fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=90114#c11">Comment # 11</a> on <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - [SNB+ Bisected]Ogles3conform ES3-CTS.shaders.struct.uniform.sampler_array_fragment fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=90114">bug 90114</a> from <a class="email" href="mailto:jason@jlekstrand.net" title="Jason Ekstrand <jason@jlekstrand.net>"> Jason Ekstrand</a> <pre>(In reply to Tapani Pälli from <a href="show_bug.cgi?id=90114#c10">comment #10</a>) > Created <a href="attachment.cgi?id=115601" name="attach_115601" title="fix for the issue">attachment 115601</a> <a href="attachment.cgi?id=115601&action=edit" title="fix for the issue">[details]</a> <a href='page.cgi?id=splinter.html&bug=90114&attachment=115601'>[review]</a> [review] > fix for the issue > > here's another try for the fix, for me this passes all of piglit and the > attached 'complex' case I'm still not convinced that's correct, but it made me look through the code again and I think I know what's going wrong. On line 81 in the direct array access case we increment sampler_index by deref->base_offset *and* add "[%u]" to the string description with deref->base_offset. Then sampler_index is incremented by the return value of get_sampler_index which should take the array offset into account *again*. Maybe we just need to remove the "instr->sampler_index += deref->base_offset" line to get rid of the double-counting.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>