<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [10.5.5/10.6 regression, bisected] PBO glDrawPixels no longer using blit fastpath"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90839#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [10.5.5/10.6 regression, bisected] PBO glDrawPixels no longer using blit fastpath"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90839">bug 90839</a>
from <span class="vcard"><a class="email" href="mailto:idr@freedesktop.org" title="Ian Romanick <idr@freedesktop.org>"> <span class="fn">Ian Romanick</span></a>
</span></b>
<pre>(In reply to Alexander Monakov from <a href="show_bug.cgi?id=90839#c14">comment #14</a>)
<span class="quote">> Sigh. Please apply this:
>
> From dae0d4b5716b9a5d9227539bb6312f1f389bfcd3 Mon Sep 17 00:00:00 2001
> From: Alexander Monakov <<a href="mailto:amonakov@ispras.ru">amonakov@ispras.ru</a>>
> Date: Tue, 9 Jun 2015 20:58:22 +0300
> Subject: [PATCH] i965: do_blit_drawpixels: decode array formats
>
> ---
> src/mesa/drivers/dri/i965/intel_pixel_draw.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_pixel_draw.c
> b/src/mesa/drivers/dri/i965/intel_pixel_draw.c
> index d68cbb6..189a592 100644
> --- a/src/mesa/drivers/dri/i965/intel_pixel_draw.c
> +++ b/src/mesa/drivers/dri/i965/intel_pixel_draw.c
> @@ -78,6 +78,8 @@ do_blit_drawpixels(struct gl_context * ctx,
> struct intel_renderbuffer *irb = intel_renderbuffer(rb);
>
> mesa_format src_format = _mesa_format_from_format_and_type(format, type);
> + if (_mesa_format_is_mesa_array_format(src_format))
> + src_format = _mesa_format_from_array_format(src_format);</span >
Assuming this fixes the problem, I'd rather see it as:
const mesa_format src_format = _mesa_format_is_mesa_array_format(src_format)
? _mesa_format_from_array_format(src_format)
: _mesa_format_from_format_and_type(format, type);
<span class="quote">> mesa_format dst_format = irb->mt->format;
>
> /* We can safely discard sRGB encode/decode for the DrawPixels interface
> */</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>