<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [10.5.5/10.6 regression, bisected] PBO glDrawPixels no longer using blit fastpath"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=90839#c16">Comment # 16</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [10.5.5/10.6 regression, bisected] PBO glDrawPixels no longer using blit fastpath"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=90839">bug 90839</a>
              from <span class="vcard"><a class="email" href="mailto:amonakov@gmail.com" title="Alexander Monakov <amonakov@gmail.com>"> <span class="fn">Alexander Monakov</span></a>
</span></b>
        <pre><span class="quote">> >     struct intel_renderbuffer *irb = intel_renderbuffer(rb);
> >  
> >     mesa_format src_format = _mesa_format_from_format_and_type(format, type);
> > +   if (_mesa_format_is_mesa_array_format(src_format))
> > +      src_format = _mesa_format_from_array_format(src_format);

> Assuming this fixes the problem, I'd rather see it as:

>    const mesa_format src_format =
> _mesa_format_is_mesa_array_format(src_format)</span >
                                    ^^^^^^^^^^

Huh?  You can't define src_format based on some predicate computed from
yet-uninitialized src_format.

<span class="quote">>       ? _mesa_format_from_array_format(src_format)
>       : _mesa_format_from_format_and_type(format, type);</span ></pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the QA Contact for the bug.</li>
      </ul>
    </body>
</html>