<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Implement a NIR -> vec4 pass" href="https://bugs.freedesktop.org/show_bug.cgi?id=89580#c20">Comment # 20</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Implement a NIR -> vec4 pass" href="https://bugs.freedesktop.org/show_bug.cgi?id=89580">bug 89580</a> from <a class="email" href="mailto:jason@jlekstrand.net" title="Jason Ekstrand <jason@jlekstrand.net>"> Jason Ekstrand</a> <pre>(In reply to Eduardo Lima Mitev from <a href="show_bug.cgi?id=89580#c19">comment #19</a>) > Last week we finished texture support and today we fixed *all* remaining > piglit regressions, compared to the vec4_visitor path. > > We still have some work left improving certain implementations and getting > rid of some FIXMEs, but we will start cleaning and squashing patches already. > > <a href="https://github.com/Igalia/mesa/commits/nir-vec4">https://github.com/Igalia/mesa/commits/nir-vec4</a> Good work! I look forward to seeing the patches. I haven't had much chance to look over things for a while. At this point, I'll probably just wait for patches unless you want feedback on something specific prior to sending them. Once we get the initial pass merged, it would be good to spend some time looking at how the NIR pass performs relative to the old fs_visitor code. One tool we have for this is shader-db. Matt ran shader-db on your branch yesterday and the instruction count is at +1% vs. non-NIR in affected programs. That is actually pretty fantastic. When we initially did the FS backend, we started out at something like +4% and when we initially did scalar VS, it started at +6%. It shouldn't take terribly long to figure out the major pain-points and get them fixed. Talk to me, Matt, or Ken offline and we'll find a way to get shader-db to you. Improving the shader-db numbers is *not* a prerequisite for getting it merged, just a prerequisite for turning it on by default.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>