<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement a NIR -> vec4 pass"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89580#c22">Comment # 22</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement a NIR -> vec4 pass"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89580">bug 89580</a>
from <span class="vcard"><a class="email" href="mailto:itoral@igalia.com" title="Iago Toral <itoral@igalia.com>"> <span class="fn">Iago Toral</span></a>
</span></b>
<pre>(In reply to Eduardo Lima Mitev from <a href="show_bug.cgi?id=89580#c21">comment #21</a>)
<span class="quote">> (In reply to Jason Ekstrand from <a href="show_bug.cgi?id=89580#c20">comment #20</a>)
> > (In reply to Eduardo Lima Mitev from <a href="show_bug.cgi?id=89580#c19">comment #19</a>)
> > > We still have some work left improving certain implementations and getting
> > > rid of some FIXMEs, but we will start cleaning and squashing patches already.
> > >
> > > <a href="https://github.com/Igalia/mesa/commits/nir-vec4">https://github.com/Igalia/mesa/commits/nir-vec4</a>
> >
> > Good work! I look forward to seeing the patches. I haven't had much chance
> > to look over things for a while. At this point, I'll probably just wait for
> > patches unless you want feedback on something specific prior to sending them.
> >
>
> Yes, it sounds good. We are preparing the patch set and hope to send it this
> week already.</span >
The current implementation only targets GLSL vertex shaders. It does not cover
geometry shaders or ARB_vertex_program, our plan was to tackle these in a
second iteration while we get feedback on the glsl vertex shader
implementation.
<span class="quote">> The only controversial part at this point is the uniform support. The way
> vec4_visitor and fs_nir handle uniform the file differ significantly. Right
> now we have the vec4_visitor implementation but to make it work well with
> nir, we have had to patch nir directly in some rather hackish ways. So Igo
> and Samuel are evaluating a full rewrite of the uniform support to have it
> similar to fs_nir layout instead. I will let them comment on it directly,
> if/when they see fit</span >
I'll explain this issue in a separate comment.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>