<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=91114#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=91114">bug 91114</a> from <a class="email" href="mailto:lemody@gmail.com" title="Tapani Pälli <lemody@gmail.com>"> Tapani Pälli</a> <pre>(In reply to Tapani Pälli from <a href="show_bug.cgi?id=91114#c3">comment #3</a>) > (In reply to Iago Toral from <a href="show_bug.cgi?id=91114#c2">comment #2</a>) > > These are the conformance tests, right? I don't think I have access to them. > > Yep, this is gles3 conformance. > > > Tapani, can you check if this change > > inlower_texture_grad_visitor::visit_leave(ir_texture *ir) fixes the problem?: > > > > - if (ir->sampler->type->sampler_dimensionality == GLSL_SAMPLER_DIM_CUBE) { > > - ir->lod_info.lod = expr(ir_binop_add, > > - expr(ir_unop_log2, rho), > > - new(mem_ctx) ir_constant(-1.0f)); > > - } else { > > ir->lod_info.lod = expr(ir_unop_log2, rho); > > - } > > > > The special case for GLSL_SAMPLER_DIM_CUBE was needed for piglit and deqp > > textureGrad tests to pass, but if this is breaking a conformance test then > > maybe there is some other factor to consider when adjusting the lod > > computation. > > unfortunately did not fix the issue huh yeah, actually it does when I added: ir->lod_info.lod = expr(ir_unop_log2, rho); (taken away by the patch)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>