<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=91114#c14">Comment # 14</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=91114">bug 91114</a> from <a class="email" href="mailto:lemody@gmail.com" title="Tapani Pälli <lemody@gmail.com>"> Tapani Pälli</a> <pre>(In reply to Iago Toral from <a href="show_bug.cgi?id=91114#c13">comment #13</a>) > (In reply to Iago Toral from <a href="show_bug.cgi?id=91114#c12">comment #12</a>) > > I don't see anything special in the generated IR. After my patch we change > > the way we compute the lod by subtracting 1 unit, but that is expected as > > per the commit log. The test itself does not seem to do weird things either > > after a quick glance at it. > > > > I am wondering if the problem may spawn from rounding issues so that > > depending on the specific test we are doing sometimes we fall on the wrong > > side of the rounding. While I was working on deqp I noticed that the problem > > was that we were computing a wrong value of LOD in all the scenarios and > > verified that subtracting 1.0 from the computed LOD fixed the problem, but > > as I explain in the commit log, I am not sure why this is needed. That > > change seemed consistent with the way in which deqp computed the expected > > result for those tests but maybe we do not need to subtract 1.0 to get the > > lod we need, maybe the problem that deqp detected was a rounding issue and > > by removing 1.0 we just fell on the right side of the rounding for those > > tests. I have just checked that for piglit, it is enough if we subtract 0.51. > > > > Tapani, could you replace my -1.0 addition by -0.51 and see if that fixes > > the CTS test? In parallel, I'll check if this is also enough for dEQP. > > dEQP seems to require -1.0 in any case, the tests only pass as long as we > subtract in the range [0.96, 1.04]. Still, it is worth knowing if such a > change would make the CTS test pass. Did not, it seems to pass with -0.01 .. -0.50 but -0.51 makes it fail.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>