<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mattst88@gmail.com" title="Matt Turner <mattst88@gmail.com>"> <span class="fn">Matt Turner</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [IVB/HSW/BDW/SKL Bisected] Lightsmark performance reduced by 7%-10%"
href="https://bugs.freedesktop.org/show_bug.cgi?id=91513">bug 91513</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>mattst88@gmail.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [IVB/HSW/BDW/SKL Bisected] Lightsmark performance reduced by 7%-10%"
href="https://bugs.freedesktop.org/show_bug.cgi?id=91513#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [IVB/HSW/BDW/SKL Bisected] Lightsmark performance reduced by 7%-10%"
href="https://bugs.freedesktop.org/show_bug.cgi?id=91513">bug 91513</a>
from <span class="vcard"><a class="email" href="mailto:mattst88@gmail.com" title="Matt Turner <mattst88@gmail.com>"> <span class="fn">Matt Turner</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=117475" name="attach_117475" title="untested patch">attachment 117475</a> <a href="attachment.cgi?id=117475&action=edit" title="untested patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=91513&attachment=117475'>[review]</a>
untested patch
I see one problem:
- switch (requested) {
- case INTEL_MIPTREE_TILING_ANY:
+ switch (layout_flags & MIPTREE_LAYOUT_ALLOC_ANY_TILED) {
+ case MIPTREE_LAYOUT_ALLOC_ANY_TILED:
break;
- case INTEL_MIPTREE_TILING_Y:
+ case MIPTREE_LAYOUT_ALLOC_YTILED:
return I915_TILING_Y;
- case INTEL_MIPTREE_TILING_NONE:
+ case MIPTREE_LAYOUT_ALLOC_LINEAR:
return I915_TILING_NONE;
}
but we have
+ MIPTREE_LAYOUT_ALLOC_YTILED = 1 << 5,
+ MIPTREE_LAYOUT_ALLOC_XTILED = 1 << 6,
+ MIPTREE_LAYOUT_ALLOC_LINEAR = 1 << 7,
};
+#define MIPTREE_LAYOUT_ALLOC_ANY_TILED (MIPTREE_LAYOUT_ALLOC_YTILED | \
+ MIPTREE_LAYOUT_ALLOC_XTILED)
the third case (MIPTREE_LAYOUT_ALLOC_LINEAR) in the switch is now impossible to
reach. I think it is supposed to be "case 0:". Please test the (untested)
attached patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>