<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [bisected] arb_gpu_shader5.execution.sampler_array_indexing.gs-struct-nonconst-sampler-nonconst crashes instead of failing" href="https://bugs.freedesktop.org/show_bug.cgi?id=91714#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [bisected] arb_gpu_shader5.execution.sampler_array_indexing.gs-struct-nonconst-sampler-nonconst crashes instead of failing" href="https://bugs.freedesktop.org/show_bug.cgi?id=91714">bug 91714</a> from <a class="email" href="mailto:jason@jlekstrand.net" title="Jason Ekstrand <jason@jlekstrand.net>"> Jason Ekstrand</a> <pre>(In reply to Timothy Arceri from <a href="show_bug.cgi?id=91714#c7">comment #7</a>) > In the end the solution I've come up with may be a little invasive for > stable as I took this as an opportunity to remove more uses of the > UniformHash table that I believe we shouldn't have to carry around anymore > but I'm pretty happy with the fix, please review. I'm planning to try and review that in the next couple of days. As far as stable goes, I'm not sure what I think. I agree that the changes are big enough that we may not want to back-port them. We could leave it as-is given that the "regression" only happens in release builds. We could also back-port just the NIR patch to get rid of the crash as long as it, by itself, doesn't break anything further; however I feel a bit dirty about that.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>