<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [UBO] Assertion for array of blocks"
href="https://bugs.freedesktop.org/show_bug.cgi?id=83508#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [UBO] Assertion for array of blocks"
href="https://bugs.freedesktop.org/show_bug.cgi?id=83508">bug 83508</a>
from <span class="vcard"><a class="email" href="mailto:apuentes@igalia.com" title="Antia Puentes <apuentes@igalia.com>"> <span class="fn">Antia Puentes</span></a>
</span></b>
<pre>(In reply to Timothy Arceri from <a href="show_bug.cgi?id=83508#c2">comment #2</a>)
<span class="quote">> (In reply to Samuel Iglesias from <a href="show_bug.cgi?id=83508#c1">comment #1</a>)
> > This is going to be fixed by AntÃa's patch:
> >
> > <a href="http://lists.freedesktop.org/archives/mesa-dev/2015-March/079102.html">http://lists.freedesktop.org/archives/mesa-dev/2015-March/079102.html</a>
> >
> > We are planning to send an updated version of this patch in the coming days.</span >
Hi! Timothy,
I have a limited knowledge about the linking code but I did take a look at how
the link_uniform_block_active_visitor works.
<span class="quote">> That will work around the issue for 'shared' and 'std140' but if a shader
> has a ubo with a 'packed' layout and is unused in the shader it will still
> hit this same problem right?</span >
I think it will not. The 'shared' and 'std140' ubo arrays are always marked as
active, regardless of they being referenced or not in the code. However, for
'packed' ubos I can see that they are marked as active by the
link_uniform_block_active_visitor *only if* there is a reference to them. By
marking them as active, I mean that they will be added by the visitor to the
'block_hash' hashtable declared in the "link_uniform_blocks" method.
<span class="quote">> The problem is the linking code always expects there to be a least one
> active use of the ubo array in the shader, I attempted to fix this but it
> REALLY expects there to be a use so its not quite as simple as you would
> expect.</span >
Could you point out where that is expected?. Thanks.
My understanding is that the linking process would only care about what we have
inside that 'block_hash' active uniform blocks hashtable and, in the case of
'packed' ubos, they only be there if they have been referenced.
<span class="quote">> I may give it another go when I have some time as I'm playing around with
> this code for AoA support currently.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>