<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [UBO] Assertion for array of blocks"
href="https://bugs.freedesktop.org/show_bug.cgi?id=83508#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [UBO] Assertion for array of blocks"
href="https://bugs.freedesktop.org/show_bug.cgi?id=83508">bug 83508</a>
from <span class="vcard"><a class="email" href="mailto:t_arceri@yahoo.com.au" title="Timothy Arceri <t_arceri@yahoo.com.au>"> <span class="fn">Timothy Arceri</span></a>
</span></b>
<pre>(In reply to Antia Puentes from <a href="show_bug.cgi?id=83508#c3">comment #3</a>)
<span class="quote">> (In reply to Timothy Arceri from <a href="show_bug.cgi?id=83508#c2">comment #2</a>)
> > (In reply to Samuel Iglesias from <a href="show_bug.cgi?id=83508#c1">comment #1</a>)
> > > This is going to be fixed by AntÃa's patch:
> > >
> > > <a href="http://lists.freedesktop.org/archives/mesa-dev/2015-March/079102.html">http://lists.freedesktop.org/archives/mesa-dev/2015-March/079102.html</a>
> > >
> > > We are planning to send an updated version of this patch in the coming days.
>
> Hi! Timothy,
>
> I have a limited knowledge about the linking code but I did take a look at
> how the link_uniform_block_active_visitor works.
>
> > That will work around the issue for 'shared' and 'std140' but if a shader
> > has a ubo with a 'packed' layout and is unused in the shader it will still
> > hit this same problem right?
>
> I think it will not. The 'shared' and 'std140' ubo arrays are always marked
> as active, regardless of they being referenced or not in the code. However,
> for 'packed' ubos I can see that they are marked as active by the
> link_uniform_block_active_visitor *only if* there is a reference to them.</span >
ok, so this was the problem. The code was broken for arrays, I've sent a patch
to the mailing list [1] and Cc'd yourself and Ian. Also sent piglit test [2]
[1] <a href="http://lists.freedesktop.org/archives/mesa-dev/2015-September/095070.html">http://lists.freedesktop.org/archives/mesa-dev/2015-September/095070.html</a>
[2] <a href="http://lists.freedesktop.org/archives/piglit/2015-September/017247.html">http://lists.freedesktop.org/archives/piglit/2015-September/017247.html</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>