<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Add FP64 support to the i965 shader backends" href="https://bugs.freedesktop.org/show_bug.cgi?id=92760#c6">Comment # 6</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Add FP64 support to the i965 shader backends" href="https://bugs.freedesktop.org/show_bug.cgi?id=92760">bug 92760</a> from <a class="email" href="mailto:itoral@igalia.com" title="Iago Toral <itoral@igalia.com>"> Iago Toral</a> <pre>While having a look at the patches I noticed a couple of obvious bugs that I thought would break things outside fp64, so I ran piglit and found that this in fact breaks a ton of things on my IVB laptop. A run of shader.py (without fp64 tests) gives: [14079/14079] skip: 7034, pass: 5104, fail: 1046, crash: 895 \ including a handful GPU hangs :( I have been fixing a lot of these today, mostly small things here and there and now we are at: [14079/14079] skip: 6973, pass: 7043, fail: 46, crash: 3 This means a total of 48 regressions compared to master excluding fp64 functionality (and only for shader.py). These regressions include 9 GPU hangs. In case you want to have a look, I have uploaded my fixes to this branch (rebased against current master too): <a href="https://github.com/Igalia/mesa/commits/connor-i965-fp64-v3-rebased">https://github.com/Igalia/mesa/commits/connor-i965-fp64-v3-rebased</a> I think we should focus on tracking and fixing the remaining regressions before moving on to doing actual fp64 stuff. BTW, right now we have things like nir_type_float and nir_type_float32, or nit_type_int and nir_type_int32...there is a number of patches in your branch that changes some uses of basic types by the bit-sized versions, and I had to add a few more in my branch to fix a good number of crashes and problems since the driver has some code paths that expect a bit-sized type in any case (in fact, they have assertions for this). Why don't we just drop the types that don't have the bit-size information completely? As it is now I think they only cause confusion and bugs.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>