<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Add FP64 support to the i965 shader backends" href="https://bugs.freedesktop.org/show_bug.cgi?id=92760#c12">Comment # 12</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Add FP64 support to the i965 shader backends" href="https://bugs.freedesktop.org/show_bug.cgi?id=92760">bug 92760</a> from <a class="email" href="mailto:itoral@igalia.com" title="Iago Toral <itoral@igalia.com>"> Iago Toral</a> <pre>(In reply to Connor Abbott from <a href="show_bug.cgi?id=92760#c11">comment #11</a>) > (In reply to Iago Toral from <a href="show_bug.cgi?id=92760#c10">comment #10</a>) > > Hi Jason, Connor: > > > > we have fixed all the regressions in gen7 and cleaned-up the code, the > > result can be found in this branch: > > > > <a href="https://github.com/Igalia/mesa/commits/i965-fp64-v4-no-regressions-clean">https://github.com/Igalia/mesa/commits/i965-fp64-v4-no-regressions-clean</a> > > > > There are probably a few more things we can squash from the top commits, but > > I don't think it is going to be much smaller than this. Right now there are > > 113 commits in there, so it is a big series (and it is not even complete!) > > > > While reviewing the code I noticed that there are some commits that fix > > things in master or are even unrelated to fp64, so we probably want to send > > these for review early. One of these commits is the nir_type_unsigned -> > > nir_type_uint rename from Jason that I guess we want to land soon to ease > > future rebases. These patches are at the beginning of the series but I moved > > them to this branch for easy reference: > > > > <a href="https://github.com/Igalia/mesa/commits/fp64-early-review">https://github.com/Igalia/mesa/commits/fp64-early-review</a> > > > > If you don't have objections I'd like to send these for review ASAP. > > Sure, go ahead. Note that earlier I sent out a series with some of those > patches: > > <a href="http://lists.freedesktop.org/archives/mesa-dev/2015-August/091724.html">http://lists.freedesktop.org/archives/mesa-dev/2015-August/091724.html</a> > > and some of them got r-b's so you can probably just push them. > > One commit I might suggest moving earlier and sending out now is "i965/vec4: > avoid dependency control around Align1 instructions". It uses the > DOUBLE_TO_FLOAT and FLOAT_TO_DOUBLE opcodes that are introduced in the > series, so you'd have to split the patch into two parts: the existing patch > minus those opcodes, and adding those opcodes back in. Then we could get the > first part reviewed now, since the thing its trying to do isn't directly > related to fp64, and it could theoretically fix existing bugs. Also, > apparently the PACK opcode I added could be used for images as well, so we > could try landing that ahead of time too. Thanks for pointing me to that. I added the Rbs the ones reviewed and pushed them. I also added a couple more unreviewed commits from that list into the bunch and send them for review to the list. I added my Rb to all of them but one for which I could not find all the relevant documentation, hopefully someone else can give the Rb to that.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>