<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:idr@freedesktop.org" title="Ian Romanick <idr@freedesktop.org>"> <span class="fn">Ian Romanick</span></a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [Regression bisected] Ogles1conform Automatic mipmap generation test is fail"
href="https://bugs.freedesktop.org/show_bug.cgi?id=93215">bug 93215</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>ASSIGNED
</td>
</tr>
<tr>
<td style="text-align:right;">Summary</td>
<td>[SKL] [Regression] Ogles1conform Automatic mipmap generation test is fail
</td>
<td>[Regression bisected] Ogles1conform Automatic mipmap generation test is fail
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [Regression bisected] Ogles1conform Automatic mipmap generation test is fail"
href="https://bugs.freedesktop.org/show_bug.cgi?id=93215#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [Regression bisected] Ogles1conform Automatic mipmap generation test is fail"
href="https://bugs.freedesktop.org/show_bug.cgi?id=93215">bug 93215</a>
from <span class="vcard"><a class="email" href="mailto:idr@freedesktop.org" title="Ian Romanick <idr@freedesktop.org>"> <span class="fn">Ian Romanick</span></a>
</span></b>
<pre>This bug is not specific to SKL. It affects all platforms that use meta. I
bisected this to:
commit acbaa3d0fcd2a0d357a4c7539d12877f9838548a
Author: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>>
Date: Fri Nov 13 11:58:41 2015 -0800
meta/generate_mipmap: Only modify the draw framebuffer binding in
fallback_required
Previously GL_FRAMEBUFFER was used. However, if GL_EXT_framebuffer_blit
is supported (note: it is supported by every Mesa driver), this is
*sometimes* an alias for GL_DRAW_FRAMEBUFFER (getters) and *sometimes*
an alias for *both* GL_DRAW_FRAMEBUFFER and GL_READ_FRAMEBUFFER
(setters). As a result, the code saved one binding but modified both.
If the bindings were different, the GL_READ_FRAMEBUFFER would be
incorrect on exit.
Fixes the piglit fbo-generatemipmap-versus-READ_FRAMEBUFFER test.
Ideally this function would use DSA functions and not modify the binding
at all. However, that would be a much more intrusive change because
_mesa_meta_bind_fbo_image would also need to be modified.
_mesa_meta_bind_fbo_image has a lot of callers. Much of this code is
about to get a major rework due to <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [BSW/BDW] ogles1conform Gets test fails"
href="show_bug.cgi?id=92363">bug #92363</a>, so I don't think it
matters too much. In fact, I discovered this bug while working on the
other bug. Le bon temps!
Signed-off-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>>
Reviewed-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>>
Cc: "10.6 11.0" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>>
(cherry picked from commit c40a88b6c5a698e5297957e28cccf2ce23820caa)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>