<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mark.a.janes@intel.com" title="Mark Janes <mark.a.janes@intel.com>"> <span class="fn">Mark Janes</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [BXT SKL regression] piglit.spec.ext_packed_float.multisample-fast-clear gl_ext_packed_float"
href="https://bugs.freedesktop.org/show_bug.cgi?id=93338">bug 93338</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>jljusten@gmail.com
</td>
<td>neil@linux.intel.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [BXT SKL regression] piglit.spec.ext_packed_float.multisample-fast-clear gl_ext_packed_float"
href="https://bugs.freedesktop.org/show_bug.cgi?id=93338#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [BXT SKL regression] piglit.spec.ext_packed_float.multisample-fast-clear gl_ext_packed_float"
href="https://bugs.freedesktop.org/show_bug.cgi?id=93338">bug 93338</a>
from <span class="vcard"><a class="email" href="mailto:mark.a.janes@intel.com" title="Mark Janes <mark.a.janes@intel.com>"> <span class="fn">Mark Janes</span></a>
</span></b>
<pre>I wrote up this bug with flawed information. This regression appears to have
been caused by the series following Jordan's patch, ending with:
ba67739b662eaf68f7a1117005e20079b2653044
References: master origin/master origin/HEAD
Author: Neil Roberts <<a href="mailto:neil@linux.intel.com">neil@linux.intel.com</a>>
AuthorDate: Thu Nov 19 15:29:19 2015 +0100
Commit: Neil Roberts <<a href="mailto:neil@linux.intel.com">neil@linux.intel.com</a>>
CommitDate: Thu Dec 10 11:03:58 2015 +0000
blit: Don't take into account the Mesa format when checking MSRT blit
According to the GLES3 spec, blitting between multisample FBOs with
different internal formats should not be allowed. The
compatible_resolve_formats function implements this check. Previously
it had a shortcut where if the Mesa formats of the two renderbuffers
were the same then it would assume the blit is ok. However some
drivers map different internal formats to the same Mesa format, for
example it might implement both GL_RGB and GL_RGBA textures with
MESA_FORMAT_R8G8B8A_UNORM. The function is used to generate a GL error
according to what the GL spec requires so the blit should not be
allowed in that case. This patch just removes the shortcut so that it
only ever looks at the internal format.
Note that I posted a related patch to disable this check altogether
for desktop GL. However this function is still used on GLES3 because
there are conformance tests that require this behaviour so this patch
is still useful.
Cc: Marek Olšák <<a href="mailto:maraeo@gmail.com">maraeo@gmail.com</a>>
Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>