<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [BDW, bisected] arb_arrays_of_arrays.execution.image_store.basic-imagestore-const-uniform-index"
href="https://bugs.freedesktop.org/show_bug.cgi?id=92822#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [BDW, bisected] arb_arrays_of_arrays.execution.image_store.basic-imagestore-const-uniform-index"
href="https://bugs.freedesktop.org/show_bug.cgi?id=92822">bug 92822</a>
from <span class="vcard"><a class="email" href="mailto:t_arceri@yahoo.com.au" title="Timothy Arceri <t_arceri@yahoo.com.au>"> <span class="fn">Timothy Arceri</span></a>
</span></b>
<pre>(In reply to Mark Janes from <a href="show_bug.cgi?id=92822#c6">comment #6</a>)
<span class="quote">> The patch seems to have resolved the issue with
> spec.arb_arrays_of_arrays.execution.image_store.basic-imagestore-non-const-
> uniform-index</span >
Thanks for testing Mark.
I have pushed these patches to the piglit repo so the issue with these tests
should be fixed as of feeefb1b47b758.
That makes 2/3 issues being tracked in this bug fixed.
Only
piglit.spec.arb_program_interface_query.arb_program_interface_query-getprogramresourceindex
remains to be fixed.
This one requires a Mesa fix, there are two options:
1.
Create a lowering pass the turns all arrays of arrays into seperate single
dimensions arrays.
For example an AoA:
in my_aoa[2][2][2];
Would become:
in my_aoa[0][0][2];
in my_aoa[0][1][2];
in my_aoa[1][0][2];
in my_aoa[1][1][2];
Where the outer two subscripts are now just part of the variable name rather
than being functional. This will also allow inactive arrays to be easily found.
However it will be a bit of work to get this correct as indirects will need to
be handled somehow as well as things such as assignments of whole AoA.
Also a bunch of clean-up would be needed as its a major change in the way AoA
are currently handled after the initial compile/linking validation is complete.
2.
The other simpler option would be to process the existing IR and store the
values we need for arb_program_interface_query in a newly allocated piece of
memory used just for interface querys.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>