<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:idr@freedesktop.org" title="Ian Romanick <idr@freedesktop.org>"> <span class="fn">Ian Romanick</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [HSW,BDW,SKL][GLES 3.1 CTS] Big difference in the results for the ES31-CTS.shader_bitfield_operation.* tests"
href="https://bugs.freedesktop.org/show_bug.cgi?id=92595">bug 92595</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>currojerez@riseup.net, idr@freedesktop.org, mattst88@gmail.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [HSW,BDW,SKL][GLES 3.1 CTS] Big difference in the results for the ES31-CTS.shader_bitfield_operation.* tests"
href="https://bugs.freedesktop.org/show_bug.cgi?id=92595#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [HSW,BDW,SKL][GLES 3.1 CTS] Big difference in the results for the ES31-CTS.shader_bitfield_operation.* tests"
href="https://bugs.freedesktop.org/show_bug.cgi?id=92595">bug 92595</a>
from <span class="vcard"><a class="email" href="mailto:idr@freedesktop.org" title="Ian Romanick <idr@freedesktop.org>"> <span class="fn">Ian Romanick</span></a>
</span></b>
<pre>(In reply to Marta Löfstedt from <a href="show_bug.cgi?id=92595#c6">comment #6</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=120561" name="attach_120561" title="Hack that fix the difference in results between HSW and BDW/SKL">attachment 120561</a> <a href="attachment.cgi?id=120561&action=edit" title="Hack that fix the difference in results between HSW and BDW/SKL">[details]</a></span>
> Hack that fix the difference in results between HSW and BDW/SKL
>
> Sorry, I attached the wrong version of the patch and did the same mistake to
> myself when testing on SKL. It is when I hack BRW_REGISTER_TYPE_UW for both
> signed and unsigned that I pass the imulExtended shader_bitfield tests on
> BDW and SKL(kernel 4.2.0).</span >
This code was originally added by 3b48a0ee (authored by Curro, reviewed by
Matt).
For Gen8, it's not obvious to me why there is any modification of the source
types of the MUL. It doesn't help that the BDW public PRM has *no*
documentation for the MUL or MACH instructions.
I'm also a little disappointed that our piglit tests didn't catch this. I
think we need a new test for [ui]mulExtended that tries more values. I think
making a big GL_RGBA32I texture that puts the sources in R and G and the
expected results (calculated by C code) in B and A should be easy enough.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>