<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [HSW,BDW,SKL][GLES 3.1 CTS] Big difference in the results for the ES31-CTS.shader_bitfield_operation.* tests" href="https://bugs.freedesktop.org/show_bug.cgi?id=92595#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [HSW,BDW,SKL][GLES 3.1 CTS] Big difference in the results for the ES31-CTS.shader_bitfield_operation.* tests" href="https://bugs.freedesktop.org/show_bug.cgi?id=92595">bug 92595</a> from <a class="email" href="mailto:mattst88@gmail.com" title="Matt Turner <mattst88@gmail.com>"> Matt Turner</a> <pre>(In reply to Marta Löfstedt from <a href="show_bug.cgi?id=92595#c6">comment #6</a>) > Created <a href="attachment.cgi?id=120561" name="attach_120561" title="Hack that fix the difference in results between HSW and BDW/SKL">attachment 120561</a> <a href="attachment.cgi?id=120561&action=edit" title="Hack that fix the difference in results between HSW and BDW/SKL">[details]</a> > Hack that fix the difference in results between HSW and BDW/SKL > > Sorry, I attached the wrong version of the patch and did the same mistake to > myself when testing on SKL. It is when I hack BRW_REGISTER_TYPE_UW for both > signed and unsigned that I pass the imulExtended shader_bitfield tests on > BDW and SKL(kernel 4.2.0). Wow, nice. I suspect that is in fact the correct fix -- the MUL intends to multiply the double word of src[0] with the low word of src[1], not the low word of src[1] with a reinterpreted sign bit. Assuming that patch has no regressions, it'll get my Reviewed-by. Thanks Marta!</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>