[Bug 58151] kernel 3.2.45 regression in i915 driver for 00:02.0 VGA compatible controller: Intel Corporation Mobile 4 Series Chipset Integrated Graphics Controller (rev 07)

[bugzilla-daemon at bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=58151





--- Comment #20 from Nix\ <nix.sasl at gmail.com>  2013-05-23 09:16:16 ---
(In reply to comment #19)
> Commit 53e587aa5ca81497d0ea6e340320ec5778d1f311 is a modified version of the
> commit in upstream master, as Ben's comment in the commit message indicates.
> Master has been changed considerably since then, and the upstream commit no
> longer applies as-is to stable v3.2. The stable v3.2 is *only* changed by
> backports of important fixes from master. Unfortunately, this "fix" added in
> 3.2.45 breaks things for you.
> 
> patch -R option *reverses* the patch, removing the code that was added by that
> commit, fixing things for you. On a git tree, this is similar to git revert
> 53e587aa5ca81497d0ea6e340320ec5778d1f311.
> 
> I presume the commit will be reverted in stable v3.2.46, which will be
> eventually picked up by distros, and get updated to users.
> 
> HTH.

@Jani Nikula

Ok, I understand much better now, and thanks a lot for the explanation about
it.
The commit 53e587aa5ca81497d0ea6e340320ec5778d1f311 that breaks things for me,
if I compare it the +/- with i915_dma.c file in 3.2.45 kernel looks that is not
applied totally. The last modification of the commit was 5-13-2013, the same
day that 3.2.45 was released.

Search 'static unsigned long i915_stolen_to_phys(struct drm_device *dev, u32
offset)' line in i915_dma.c of 3.2.45, the line are present (I assume that "-"
in patch remove things and "+" add things), so the commit never modified *all*
code?.

If you download 3.2.45 kernel, and execute # cat
./drivers/gpu/drm/i915/i915_dma.c |grep -i static unsigned long
i915_stolen_to_phys(struct drm_device *dev, u32 offset) is present, but, the
commit remove the line (using "-" symbol), so, was really applied the commit.


http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=53e587aa5ca81497d0ea6e340320ec5778d1f311

-static unsigned long i915_stolen_to_phys(struct drm_device *dev, u32 offset)
+static unsigned long i915_stolen_to_physical(struct drm_device *dev)

In the 3.2.45 downloaded from http://kernel.org, the line 'static unsigned long
i915_stolen_to_phys(struct drm_device *dev, u32 offset) exist, and the line
'static unsigned long i915_stolen_to_physical(struct drm_device *dev)' not, is
a example of a lot of lines not changed by the buggy commit.

So, the commit 53e587aa5ca81497d0ea6e340320ec5778d1f311 modify the source
totally?. If was modified in master branch 5-13-2013, the same day that 3.2.45
was released, and applied, why the changes are no totally applied? in .c
files?.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.