<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO --- - [i945GM regression] in 3.7.0 kernel on macbook1,1 (kernel crash)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=58396#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO --- - [i945GM regression] in 3.7.0 kernel on macbook1,1 (kernel crash)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=58396">bug 58396</a>
from <span class="vcard"><a class="email" href="mailto:peter.ujfalusi@gmail.com" title="Peter Ujfalusi <peter.ujfalusi@gmail.com>"> <span class="fn">Peter Ujfalusi</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=58396#c11">comment #11</a>)
<span class="quote">> More succinct: We did change the sense of the "plane enabled?" check, but we
> also inverted the plane we actually check (see the added ! in reg =
> DSPCNTR(!crtc->plane);)</span >
Hrm, should the crtc->pipe need to be inverted as well?
Based on your earlier comment about the change in the check:
<span class="quote">> whereas the new one whether the wrong plane is enabled and on the wrong pipe.</span >
Something like this, so we check on the 'wrong plane' and on the 'wrong pipe':
@@ -8114,7 +8114,7 @@ intel_check_plane_mapping(struct intel_crtc *crtc)
val = I915_READ(reg);
if ((val & DISPLAY_PLANE_ENABLE) &&
- (!!(val & DISPPLANE_SEL_PIPE_MASK) == crtc->pipe))
+ (!!(val & DISPPLANE_SEL_PIPE_MASK) == !crtc->pipe))
return false;
Not sure... Will see when I get my hands on my laptop.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>