<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [i915GM regression] black screen after blank when LID is closed on Linux >= 3.1"
href="https://bugs.freedesktop.org/show_bug.cgi?id=57434#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [i915GM regression] black screen after blank when LID is closed on Linux >= 3.1"
href="https://bugs.freedesktop.org/show_bug.cgi?id=57434">bug 57434</a>
from <span class="vcard"><a class="email" href="mailto:daniel@ffwll.ch" title="Daniel Vetter <daniel@ffwll.ch>"> <span class="fn">Daniel Vetter</span></a>
</span></b>
<pre>Nice debug work! One small change request to test for your patch: Does it still
work if you move the call to i915_redisable_vga up into the force_restore
block, i.e.
if (force_restore) {
for_each_pipe(pipe) {
crtc = to_intel_crtc(dev_priv->pipe_to_crtc_mapping[pipe]);
intel_set_mode(&crtc->base, &crtc->base.mode,
crtc->base.x, crtc->base.y, crtc->base.fb);
}
i915_redisable_vga(dev);
} else {
intel_modeset_update_staged_output_state(dev);
}
force_restore is already used to unbreak BIOS damage, so would fit in nicer.
Then please submit the final patch with
Bugzilla: <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [i915GM regression] black screen after blank when LID is closed on Linux >= 3.1"
href="show_bug.cgi?id=57434">https://bugs.freedesktop.org/show_bug.cgi?id=57434</a>
added to <a href="mailto:intel-gfx@lists.freedesktop.org">intel-gfx@lists.freedesktop.org</a>, so that I can include it (you don't
have to be subscribed).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>