<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [HSW]igt/module_reload randomly causes system hang" href="https://bugs.freedesktop.org/show_bug.cgi?id=65880#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [HSW]igt/module_reload randomly causes system hang" href="https://bugs.freedesktop.org/show_bug.cgi?id=65880">bug 65880</a> from <a class="email" href="mailto:yangweix.shui@intel.com" title="shui yangwei <yangweix.shui@intel.com>"> shui yangwei</a> <pre>bisect shows: commit eda63ffb906c2fb3b609a0e87aeb63c0f25b9e6b is the first bad commit. commit eda63ffb906c2fb3b609a0e87aeb63c0f25b9e6b Author: Ben Widawsky <<a href="mailto:ben@bwidawsk.net">ben@bwidawsk.net</a>> AuthorDate: Tue May 28 19:22:26 2013 -0700 Commit: Daniel Vetter <<a href="mailto:daniel.vetter@ffwll.ch">daniel.vetter@ffwll.ch</a>> CommitDate: Fri May 31 20:54:16 2013 +0200 drm/i915: Add PM regs to pre/post install At the moment, these values are wiped out anyway by the rps enable/disable. That will be changed in the next patch though. v2: Add post install setup to address issue found by Damien in the next patch. replaced WARN_ON(dev_priv->rps.pm_iir != 0); with rps.pm_iir = 0; With the v2 of this patch and the deferred pm enabling (which changed since the original patches) we're now able to get PM interrupts before we've brought up enabled rps. At this point in boot, we don't want to do anything about it, so we simply ignore it. Since writing the original assertion, the code has changed quite a bit, and I believe removing this assertion is perfectly safe. Signed-off-by: Ben Widawsky <<a href="mailto:ben@bwidawsk.net">ben@bwidawsk.net</a>> Reviewed-by: Damien Lespiau <<a href="mailto:damien.lespiau@intel.com">damien.lespiau@intel.com</a>> [danvet: I don't agree with the justification to drop the WARN and added a FIXME to that effect.] Signed-off-by: Daniel Vetter <<a href="mailto:daniel.vetter@ffwll.ch">daniel.vetter@ffwll.ch</a>></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>