<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - intel-virtual-overlay: only background image and mouse cursor"
href="https://bugs.freedesktop.org/show_bug.cgi?id=68987#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - intel-virtual-overlay: only background image and mouse cursor"
href="https://bugs.freedesktop.org/show_bug.cgi?id=68987">bug 68987</a>
from <span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span></b>
<pre>Whoops, that assert failure was a silly use of sprintf.
commit f01c5eae2a3d6efebe9332a8654303356e622bec
Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
Date: Thu Sep 5 17:48:20 2013 +0100
intel-virtual-output: Reserve space for the '\0' in the sprintf
Even though we don't use the trailing NUL byte for our comparisons,
sprintf will write it, so we need make space for it.
Reported-by: Severin Strobl <<a href="mailto:fd@severin-strobl.de">fd@severin-strobl.de</a>>
Bugzilla: <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - intel-virtual-overlay: only background image and mouse cursor"
href="show_bug.cgi?id=68987">https://bugs.freedesktop.org/show_bug.cgi?id=68987</a>
Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
The idea is that only one intel-virtual-output exists (otherwise we have fun
with multiple processes conflicting over the allocation of VIRTUAL), so if you
run it a second time it sends the request for new screens to the first process.
(There's a timeout for it detection the old process expired.)
The problem appears to lie in damage tracking. We get nothing reported, so we
don't draw any updates.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>