<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - intel-virtual-overlay: only background image and mouse cursor"
href="https://bugs.freedesktop.org/show_bug.cgi?id=68987#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - intel-virtual-overlay: only background image and mouse cursor"
href="https://bugs.freedesktop.org/show_bug.cgi?id=68987">bug 68987</a>
from <span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span></b>
<pre>Looks ok, no errors, just the damage stops coming. What may be significant is
that it occurs when we reconfigure the screen for the virtual outputs. There
have been a number of Xserver bugs in the past where Damage breaks across a
modeset, so I wonder if this is another...
Maybe this will workaround the issue?
diff --git a/tools/virtual.c b/tools/virtual.c
index 257f37f..4da2f3a 100644
--- a/tools/virtual.c
+++ b/tools/virtual.c
@@ -1760,9 +1760,22 @@ static int display_init_damage(struct display *display)
if (display->damage == 0)
return EACCES;
+ display->flush = 1;
return 0;
}
+static void display_reset_damage(struct display *display)
+{
+ Damage damage;
+
+ damage = XDamageCreate(display->dpy, display->root,
XDamageReportRawRectangles);
+ if (damage) {
+ XDamageDestroy(display->dpy, display->damage);
+ display->damage = damage;
+ display->flush = 1;
+ }
+}
+
static void display_init_randr_hpd(struct display *display)
{
int major, minor;
@@ -2632,8 +2645,10 @@ int main(int argc, char **argv)
ret--;
}
- if (reconfigure)
+ if (reconfigure) {
context_update(&ctx);
+ display_reset_damage(ctx.display);
+ }
if (rr_update) {
for (i = 0; i < ctx.nclone; i++)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>