<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [hsw] X server crash while scrolling in firefox"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70204">70204</a>
</td>
</tr>
<tr>
<th>CC</th>
<td>intel-gfx-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Assignee</th>
<td>intel-gfx-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Summary</th>
<td>[hsw] X server crash while scrolling in firefox
</td>
</tr>
<tr>
<th>QA Contact</th>
<td>intel-gfx-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Severity</th>
<td>major
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux (All)
</td>
</tr>
<tr>
<th>Reporter</th>
<td>joe.yasi@gmail.com
</td>
</tr>
<tr>
<th>Hardware</th>
<td>x86-64 (AMD64)
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Version</th>
<td>XOrg CVS
</td>
</tr>
<tr>
<th>Component</th>
<td>DRM/Intel
</td>
</tr>
<tr>
<th>Product</th>
<td>DRI
</td>
</tr></table>
<p>
<div>
<pre>The X server crashes while scrolling some webpages in Firefox as of commit
c98b770. I have bisected it down to that commit. 27ad2fc did not compile. I got
it to compile by grabbing the change to trapezoids_bounds from c98b770 (below).
I cannot reproduce the crash with 27ad2fc.
--- a/src/sna/sna_trapezoids.c
+++ b/src/sna/sna_trapezoids.c
@@ -70,7 +70,7 @@
return l->p1.x + (xFixed) (ex / d);
}
-void trapezoids_bounds(int n, const xTrapezoid *t, BoxPtr box)
+bool trapezoids_bounds(int n, const xTrapezoid *t, BoxPtr box)
{
xFixed x1, y1, x2, y2;
@@ -134,6 +134,8 @@
box->x2 = pixman_fixed_to_int(x2);
box->y1 = pixman_fixed_integer_floor(y1);
box->y2 = pixman_fixed_integer_ceil(y2);
+
+ return box->x2 > box->x1 && box->y2 > box->y1;
}
static bool
--- a/src/sna/sna_trapezoids.h
+++ b/src/sna/sna_trapezoids.h
@@ -212,7 +212,7 @@
return (v + ((1<<(16-FAST_SAMPLES_shift-1))-1)) >> (16 -
FAST_SAMPLES_shift);
}
-void trapezoids_bounds(int n, const xTrapezoid *t, BoxPtr box);
+bool trapezoids_bounds(int n, const xTrapezoid *t, BoxPtr box);
static inline bool
is_mono(PicturePtr dst, PictFormatPtr mask)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>