<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - vgaswitcheroo hibernation problem" href="https://bugs.freedesktop.org/show_bug.cgi?id=70863#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - vgaswitcheroo hibernation problem" href="https://bugs.freedesktop.org/show_bug.cgi?id=70863">bug 70863</a> from <a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> Chris Wilson</a> <pre>Just a couple of things I noticed as someone not familiar with vgasr: 1. Can you please put a description of the failure (the user impact) into the changelog? I am guessing that it spans from excess power usage to blank displays. It should also explain why we need to restore the old state rather than waking up userspace in the brave new world, and why we only turn devices off rather than powering others to match pwr_state. 2. in vga_restore_power_state() it looks like you should be performing a similar operation to vga_switchon/vga_switchoff, that is you may need a client->ops->set_gpu_state(). 3. vga_switcheroo_disable() should reset mux_state = MUX_STATE_UNDEFINED (or do so in vga_switcheroo_enable()). 4. vga_restore_mux() failure should probably also reset mux_state = MUX_STATE_UNDEFINED</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> </ul> </body> </html>