<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - [IVB] Undocking laptop causes warning in intel_dp_link_down+0x1d2/0x210" href="https://bugs.freedesktop.org/show_bug.cgi?id=70839#c13">Comment # 13</a> on <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - [IVB] Undocking laptop causes warning in intel_dp_link_down+0x1d2/0x210" href="https://bugs.freedesktop.org/show_bug.cgi?id=70839">bug 70839</a> from <a class="email" href="mailto:imre.deak@gmail.com" title="Imre Deak <imre.deak@gmail.com>"> Imre Deak</a> <pre>(In reply to <a href="show_bug.cgi?id=70839#c11">comment #11</a>) > Ah, sorry that I was looking in a wrong branch. > Indeed, the commit in question will remove the warning, as it removes the > call to intel_dp_link_down() from intel_dp_check_link_status(). > However, my understanding is that this call was there to support cases where > userspace doesn't handle uevents, and removing it will leave DP link on and > consuming power in such systems, and probably lead to errors when one > monitor is plugged out and another is plugged in. Hope you are keeping track > of this in some other bug. In general we do depend on user space handling uevents, I don't know any reason why guaranteeing this would pose any problem. So the subsequent modeset disable should take care of disabling the port. Note that there is still a TODO identified by Chris, for the case where a modeset fails due to link training errors and we leave the whole pipeline enabled. But that's a somewhat separate issue. > But, for me the problem is fixed, so you can close this one. > > BTW, if relying on uevents is the direction you want to proceed with, I > think you can remove intel_dp_hot_plug() altogether, since currently it does > nothing in case of unplug, and in case of plug, the dp link will be enabled > in intel_enable_dp() anyway, when userspace decides to DPMS_ON. Afaics intel_dp_hot_plug() also handles link retraining.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> </ul> </body> </html>