<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_REOPENED " title="REOPENED --- - [snb] vsync hang" href="https://bugs.freedesktop.org/show_bug.cgi?id=68718#c21">Comment # 21</a> on <a class="bz_bug_link bz_status_REOPENED " title="REOPENED --- - [snb] vsync hang" href="https://bugs.freedesktop.org/show_bug.cgi?id=68718">bug 68718</a> from <a class="email" href="mailto:imirkin@alum.mit.edu" title="Ilia Mirkin <imirkin@alum.mit.edu>"> Ilia Mirkin</a> <pre>(In reply to <a href="show_bug.cgi?id=68718#c20">comment #20</a>) > Guessing now, but maybe try this delta patch on top: > > diff --git a/src/sna/sna_display.c b/src/sna/sna_display.c > index 99afbd1..2620669 100644 > --- a/src/sna/sna_display.c > +++ b/src/sna/sna_display.c > @@ -3984,7 +3984,7 @@ static bool sna_emit_wait_for_scanline_gen6(struct sna > *sna, > b = kgem_get_batch(&sna->kgem); > > /* Both the LRI and WAIT_FOR_EVENT must be in the same cacheline */ > - if (((sna->kgem.nbatch + 6) >> 4) != (sna->kgem.nbatch + 9) >> 4) { > + if (((sna->kgem.nbatch + 6) >> 3) != (sna->kgem.nbatch + 10) >> 3) { Is the +9 -> +10 on purpose? That doesn't seem cache-line-equality-related... > int dw = sna->kgem.nbatch + 6; > dw = ALIGN(dw, 16) - dw; > while (dw--) > > > I think the cacheline it mentions is 64bytes, but we may as check against > 32bytes just in case.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>