<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [ilk] Corrupted glyph rendering of Stylish entry in Firefox Add-ons tab"
href="https://bugs.freedesktop.org/show_bug.cgi?id=74882#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [ilk] Corrupted glyph rendering of Stylish entry in Firefox Add-ons tab"
href="https://bugs.freedesktop.org/show_bug.cgi?id=74882">bug 74882</a>
from <span class="vcard"><a class="email" href="mailto:itumaykin@gmail.com" title="Coacher <itumaykin@gmail.com>"> <span class="fn">Coacher</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=74882#c4">comment #4</a>)
<span class="quote">> That's a little scary. How about
>
> diff --git a/src/sna/gen5_render.c b/src/sna/gen5_render.c
> index a9db697..0755fd2 100644
> --- a/src/sna/gen5_render.c
> +++ b/src/sna/gen5_render.c
> @@ -54,7 +54,7 @@
> #define DBG_NO_STATE_CACHE 0
> #define DBG_NO_SURFACE_CACHE 0
>
> -#define ALWAYS_FLUSH 0
> +#define ALWAYS_FLUSH 1
>
> #define MAX_3D_SIZE 8192
>
> @@ -1049,7 +1049,7 @@ gen5_emit_state(struct sna *sna,
> }
> gen5_emit_vertex_elements(sna, op);
>
> - if (kgem_bo_is_dirty(op->src.bo) || kgem_bo_is_dirty(op->mask.bo)) {
> + if (ALWAYS_FLUSH || kgem_bo_is_dirty(op->src.bo) ||
> kgem_bo_is_dirty(op->mask.bo)) {
> DBG(("%s: flushing dirty (%d, %d)\n", __FUNCTION__,
> kgem_bo_is_dirty(op->src.bo),
> kgem_bo_is_dirty(op->mask.bo)));
> @@ -1058,7 +1058,7 @@ gen5_emit_state(struct sna *sna,
> kgem_bo_mark_dirty(op->dst.bo);
> flush = false;
> }
> - if (flush || ALWAYS_FLUSH) {
> + if (flush) {
> DBG(("%s: forcing flush\n", __FUNCTION__));
> gen5_emit_pipe_flush(sna);
>
> instead?
>
> i.e. enable ALWAYS_FLUSH and use it to force the full flush rather than the
> pipeline flush.</span >
This patch is not appliable on top of 27663f31163c22f7dfaf8f5a3e45fa1c93a7d9e4.
Will pull and try again.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>