<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEEDINFO " title="NEEDINFO --- - [BYT Regression]Some subcases of igt/kms_flip timeout" href="https://bugs.freedesktop.org/show_bug.cgi?id=76987#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEEDINFO " title="NEEDINFO --- - [BYT Regression]Some subcases of igt/kms_flip timeout" href="https://bugs.freedesktop.org/show_bug.cgi?id=76987">bug 76987</a> from <a class="email" href="mailto:imre.deak@gmail.com" title="Imre Deak <imre.deak@gmail.com>"> Imre Deak</a> <pre>(In reply to <a href="show_bug.cgi?id=76987#c1">comment #1</a>) > Hm, that warning is fairly old, so no idea why stuff started to go boom here. > > Can you please try to bisect where this regression has been introduced? > > Adding Jani in case it turns out to be the dp aux rework, but the only open > issue we know of should result in this kind of warning. dp_aux_ch not started status 0xffffffff and a bunch of WARNING: CPU: 0 PID: 4 at drivers/gpu/drm/i915/intel_pm.c:5652 intel_display_power_put+0x39/0xf8 [i915]() make me think this is a power domain refcounting issue. One idea for the reason is the unbalanced vdd_on/off calls we discussed and the fix would be (based on your suggestion): diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index e48d47c..c7a52d1 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -313,8 +313,12 @@ static bool edp_have_panel_vdd(struct intel_dp *intel_dp) { struct drm_device *dev = intel_dp_to_dev(intel_dp); struct drm_i915_private *dev_priv = dev->dev_private; + struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); + struct intel_encoder *intel_encoder = &intel_dig_port->base; + enum intel_display_power_domain power_domain; - return !dev_priv->pm.suspended && + power_domain = intel_display_port_power_domain(intel_encoder); + return intel_display_power_enabled(dev_priv, power_domain) && (I915_READ(_pp_ctrl_reg(intel_dp)) & EDP_FORCE_VDD) != 0; }</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> </ul> </body> </html>