<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO --- - [gm45 regression] [drm:init_ring_common]: *ERROR* render ring initialization failed"
href="https://bugs.freedesktop.org/show_bug.cgi?id=76554#c41">Comment # 41</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO --- - [gm45 regression] [drm:init_ring_common]: *ERROR* render ring initialization failed"
href="https://bugs.freedesktop.org/show_bug.cgi?id=76554">bug 76554</a>
from <span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span></b>
<pre>One last paste... (Apologies for any white space issues, this is just trying to
be quick and dirty.)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 5a74986348c6..75365c1588fb 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -526,9 +526,28 @@ static int init_ring_common(struct intel_ring_buffer
*ring)
* also enforces ordering), otherwise the hw might lose the new ring
* register values. */
I915_WRITE_START(ring, i915_gem_obj_ggtt_offset(obj));
+ if (wait_for(I915_READ_START(ring) == i915_gem_obj_ggtt_offset(obj),
+ 1000)) {
+ DRM_ERROR("%s initialization failed "
+ "start %08x [expected %08lx]\n",
+ ring->name,
+ I915_READ_START(ring),
+ (unsigned long)i915_gem_obj_ggtt_offset(obj));
+ ret = -EIO;
+ goto out;
+ }
+
I915_WRITE_CTL(ring,
((ring->size - PAGE_SIZE) & RING_NR_PAGES)
| RING_VALID);
+ if (wait_for(I915_READ_CTL(ring) & RING_VALID, 1000)) {
+ DRM_ERROR("%s initialization failed ctl %08x (valid? %d)\n",
+ ring->name,
+ I915_READ_CTL(ring),
+ !!(I915_READ_CTL(ring) & RING_VALID));
+ ret = -EIO;
+ goto out;
+ }</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>