<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - intel framebuffer broken by d978ef14456a38034f6c0e94a794129501f89200 in kernel 3.15-rc"
href="https://bugs.freedesktop.org/show_bug.cgi?id=77767#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - intel framebuffer broken by d978ef14456a38034f6c0e94a794129501f89200 in kernel 3.15-rc"
href="https://bugs.freedesktop.org/show_bug.cgi?id=77767">bug 77767</a>
from <span class="vcard"><a class="email" href="mailto:Knut_Petersen@t-online.de" title="Knut Petersen <Knut_Petersen@t-online.de>"> <span class="fn">Knut Petersen</span></a>
</span></b>
<pre>Yes, that cures the problem. I'd suggest to put the expression after "&&" into
parentheses, otherwise the compiler complains ...
Thanks!
cu,
Knut
(In reply to <a href="show_bug.cgi?id=77767#c7">comment #7</a>)
<span class="quote">> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c
> b/drivers/gpu/drm/i915/intel_fbdev.c
> index b16116db6c37..24463b643fc8 100644
> --- a/drivers/gpu/drm/i915/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> @@ -133,6 +133,12 @@ static int intelfb_create(struct drm_fb_helper *helper,
>
> mutex_lock(&dev->struct_mutex);
>
> + if (intel_fb &&
> + sizes->fb_width > intel_fb->base.width ||
> + sizes->fb_height > intel_fb->base.height) {
> + drm_framebuffer_reference(&ifbdev->fb->base);
> + intel_fb = NULL;
> + }
> if (!intel_fb || WARN_ON(!intel_fb->obj)) {
> DRM_DEBUG_KMS("no BIOS fb, allocating a new one\n");
> ret = intelfb_alloc(helper, sizes);</span >
(In reply to <a href="show_bug.cgi?id=77767#c7">comment #7</a>)
<span class="quote">> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c
> b/drivers/gpu/drm/i915/intel_fbdev.c
> index b16116db6c37..24463b643fc8 100644
> --- a/drivers/gpu/drm/i915/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> @@ -133,6 +133,12 @@ static int intelfb_create(struct drm_fb_helper *helper,
>
> mutex_lock(&dev->struct_mutex);
>
> + if (intel_fb &&
> + sizes->fb_width > intel_fb->base.width ||
> + sizes->fb_height > intel_fb->base.height) {
> + drm_framebuffer_reference(&ifbdev->fb->base);
> + intel_fb = NULL;
> + }
> if (!intel_fb || WARN_ON(!intel_fb->obj)) {
> DRM_DEBUG_KMS("no BIOS fb, allocating a new one\n");
> ret = intelfb_alloc(helper, sizes);</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>