<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED --- - [PNV/ILK Regression]igt/drv_suspend/debugfs-reader fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=77717#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED --- - [PNV/ILK Regression]igt/drv_suspend/debugfs-reader fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=77717">bug 77717</a> from <a class="email" href="mailto:jinxianx.guo@intel.com" title="Guo Jinxian <jinxianx.guo@intel.com>"> Guo Jinxian</a> <pre>(In reply to <a href="show_bug.cgi?id=77717#c3">comment #3</a>) > 691e6415c891b8b2b082a120b896b443531c4d45 is the first bad commit > commit 691e6415c891b8b2b082a120b896b443531c4d45 > Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> > AuthorDate: Wed Apr 9 09:07:36 2014 +0100 > Commit: Jani Nikula <<a href="mailto:jani.nikula@intel.com">jani.nikula@intel.com</a>> > CommitDate: Fri Apr 11 13:29:51 2014 +0300 > > drm/i915: Always use kref tracking for all contexts. > > If we always initialize kref for the context, even if we are using fake > contexts for hangstats when there is no hw support, we can forgo the > dance to dereference the ctx->obj and inspect whether we are permitted > to use kref inside i915_gem_context_reference() and _unreference(). > > My ulterior motive here is to improve the debugging of a use-after-free > of ctx->obj. This patch avoids the dereference here and instead forces > the assertion checks associated with kref. > > v2: Refactor the fake contexts to being even more like the real > contexts, so that there is much less duplicated and special case code. > > v3: Tweaks. > v4: Tweaks, minor. > > Bugzilla: <a class="bz_bug_link bz_status_VERIFIED bz_closed" title="VERIFIED FIXED - [PNV/ILK Regression]X will be no response when run all piglit cases" href="show_bug.cgi?id=76671">https://bugs.freedesktop.org/show_bug.cgi?id=76671</a> > Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> > Tested-by: lu hua <<a href="mailto:huax.lu@intel.com">huax.lu@intel.com</a>> > Cc: Ben Widawsky <<a href="mailto:benjamin.widawsky@intel.com">benjamin.widawsky@intel.com</a>> > Cc: Mika Kuoppala <<a href="mailto:mika.kuoppala@intel.com">mika.kuoppala@intel.com</a>> > Reviewed-by: Ben Widawsky <<a href="mailto:ben@bwidawsk.net">ben@bwidawsk.net</a>> > [Jani: tiny change to backport to drm-intel-fixes.] > Signed-off-by: Jani Nikula <<a href="mailto:jani.nikula@intel.com">jani.nikula@intel.com</a>> > > :040000 040000 b9a776bb2de3ba84f614087619e9e91a2bdcc960 > e5dd0a22c4ec8df198400605e960f8c683e732ed M drivers Revert the commit on latest -fixes, The case will successed.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> </ul> </body> </html>