<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:daniel@ffwll.ch" title="Daniel Vetter <daniel@ffwll.ch>"> <span class="fn">Daniel Vetter</span></a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED --- - WARNING: CPU: 1 PID: 1961 at drivers/gpu/drm/i915/intel_sprite.c:58 intel_pipe_update_start"
href="https://bugs.freedesktop.org/show_bug.cgi?id=78114">bug 78114</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>ASSIGNED
</td>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>daniel@ffwll.ch
</td>
<td>chris@chris-wilson.co.uk
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED --- - WARNING: CPU: 1 PID: 1961 at drivers/gpu/drm/i915/intel_sprite.c:58 intel_pipe_update_start"
href="https://bugs.freedesktop.org/show_bug.cgi?id=78114#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED --- - WARNING: CPU: 1 PID: 1961 at drivers/gpu/drm/i915/intel_sprite.c:58 intel_pipe_update_start"
href="https://bugs.freedesktop.org/show_bug.cgi?id=78114">bug 78114</a>
from <span class="vcard"><a class="email" href="mailto:daniel@ffwll.ch" title="Daniel Vetter <daniel@ffwll.ch>"> <span class="fn">Daniel Vetter</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=78114#c2">comment #2</a>)
<span class="quote">> Could it be as simple as
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c
> b/drivers/gpu/drm/i915/i915_drv.c
> index 36bdbdfbedb0..160b4b5eb125 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -476,8 +476,11 @@ static int i915_drm_freeze(struct drm_device *dev)
> * for _thaw.
> */
> mutex_lock(&dev->mode_config.mutex);
> - list_for_each_entry(crtc, &dev->mode_config.crtc_list, head)
> + list_for_each_entry(crtc, &dev->mode_config.crtc_list, head)
> {
> + mutex_lock(&crtc->mutex);
> dev_priv->display.crtc_disable(crtc);
> + mutex_unlock(&crtc->mutex);
> + }
> mutex_unlock(&dev->mode_config.mutex);
>
> intel_modeset_suspend_hw(dev);
>
> ?</span >
Has my review, definitely. Please submit to intel-gfx.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>