<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED NOTOURBUG - [Regression][[i945] Crashes and bad performance on Lenovo X60 with coreboot and native graphics init"
href="https://bugs.freedesktop.org/show_bug.cgi?id=79038#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED NOTOURBUG - [Regression][[i945] Crashes and bad performance on Lenovo X60 with coreboot and native graphics init"
href="https://bugs.freedesktop.org/show_bug.cgi?id=79038">bug 79038</a>
from <span class="vcard"><a class="email" href="mailto:paulepanter@users.sourceforge.net" title="Paul Menzel <paulepanter@users.sourceforge.net>"> <span class="fn">Paul Menzel</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=79038#c11">comment #11</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=79038#c8">comment #8</a>)
> > The BIOS is lying entirely about the layout of memory. Other than quirking
> > and refusing to load on coreboot, what do you propose?
>
> Can the incorrect layout be detected and the stolen memory feature be
> disabled in that case?</span >
Looking at your Linux patch again, my statement is incorrect, in that the
“stolen memory” feature was used before, but now the Graphics Base of Stolen
Memory is determined in a different way.
Before:
u8 val;
/* Stolen is immediately below Top of Low Usable DRAM */
pci_read_config_byte(pdev, 0x9c, &val);
base = val >> 3 << 27;
base -= dev_priv->mm.gtt->stolen_size;
After:
pci_read_config_dword(dev->pdev, 0x5c, &base);
base &= ~((1<<20) - 1);
Could a switch be added which method to use, which the user can add on the
command line?
I agree that it sucks, but LibreBoot already shipped laptops with that
firmware, so we cannot force the users to upgrade the firmware. A module option
would be a good compromise, as far as I see it.
<span class="quote">> > It is safe to say that coreboot does not yet fulfill its function as a BIOS.
>
> First, coreboot does not try to be a BIOS. :p Please keep in mind, that it
> works fine when running/using the VGA BIOS instead of doing native graphics
> init.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>