<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO --- - [SNA G33/31] xorg/ddx hits kgem_check_many_bo_fenced: Assertion `bo->refcnt' failed."
href="https://bugs.freedesktop.org/show_bug.cgi?id=79238">bug 79238</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>NEEDINFO
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO --- - [SNA G33/31] xorg/ddx hits kgem_check_many_bo_fenced: Assertion `bo->refcnt' failed."
href="https://bugs.freedesktop.org/show_bug.cgi?id=79238#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO --- - [SNA G33/31] xorg/ddx hits kgem_check_many_bo_fenced: Assertion `bo->refcnt' failed."
href="https://bugs.freedesktop.org/show_bug.cgi?id=79238">bug 79238</a>
from <span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span></b>
<pre>Went ahead and pushed:
commit 9f4f855ba37966fb91d31e9081d03cf72affb154
Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
Date: Mon May 26 07:06:18 2014 +0100
sna: Implicit release of upload buffers considered bad
Currently upload buffers are automatically decoupled when the buffer is
retired. As retiring can happen during command setup after we have
selected which bo to render with, this can free the bo we plan to use.
Which is bad.
Instead of making the release of upload buffers automatic, we manually
check whether the buffer is idle before use as a source to consider
scrapping it and replacing it with a real GPU bo. This is likely to keep
upload buffers alive for longer (limiting reuse between Pixmaps but
making reuse of the buffer within a Pixmap more likely) which is both
good and bad. (Good - may improve the content cache, bad - may increase
the amount of memory used by upload buffers for arbitrary long periods.)
Reported-by: Matti Hämäläinen <<a href="mailto:ccr@tnsp.org">ccr@tnsp.org</a>>
Bugzilla: <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO --- - [SNA G33/31] xorg/ddx hits kgem_check_many_bo_fenced: Assertion `bo->refcnt' failed."
href="show_bug.cgi?id=79238">https://bugs.freedesktop.org/show_bug.cgi?id=79238</a>
Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
commit b508d8f3318c42a2a87b7731789b1d03610e9b46
Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
Date: Mon May 26 06:54:03 2014 +0100
sna: Assert that we do not replace active IO buffers
References: <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO --- - [SNA G33/31] xorg/ddx hits kgem_check_many_bo_fenced: Assertion `bo->refcnt' failed."
href="show_bug.cgi?id=79238">https://bugs.freedesktop.org/show_bug.cgi?id=79238</a>
Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>