<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:wendy.wang@intel.com" title="wendy.wang@intel.com">wendy.wang@intel.com</a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [BSW] 3rd S3 fail with error, with i915 loaded"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84903">bug 84903</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEEDINFO
</td>
<td>ASSIGNED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [BSW] 3rd S3 fail with error, with i915 loaded"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84903#c18">Comment # 18</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [BSW] 3rd S3 fail with error, with i915 loaded"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84903">bug 84903</a>
from <span class="vcard"><a class="email" href="mailto:wendy.wang@intel.com" title="wendy.wang@intel.com">wendy.wang@intel.com</a>
</span></b>
<pre>(In reply to Ville Syrjala from <a href="show_bug.cgi?id=84903#c17">comment #17</a>)
<span class="quote">> (In reply to wendy.wang from <a href="show_bug.cgi?id=84903#c13">comment #13</a>)
> > (In reply to Ville Syrjala from <a href="show_bug.cgi?id=84903#c11">comment #11</a>)
> > > (In reply to wendy.wang from <a href="show_bug.cgi?id=84903#c10">comment #10</a>)
> > > > Created <span class=""><a href="attachment.cgi?id=110297" name="attach_110297" title="V47_s3_dmesg.log">attachment 110297</a> <a href="attachment.cgi?id=110297&action=edit" title="V47_s3_dmesg.log">[details]</a></span>
> > > > V47_s3_dmesg.log
> > > >
> > > > Sorry, attached v47-s3-dmesg log file.
> > >
> > > There's no failure in the log. Just a warning about new_config being out of
> > > whack
> > > "[ 737.980749] WARN_ON(intel_crtc->new_config && intel_crtc->new_config !=
> > > &intel_crtc->config)"
> > >
> > > It's harmless, but if you want to get rid of it you can cherry-pick
> > > commit 2d3d111a8f34606469e589d3491c9a64f62310b8
> > > Author: Ville Syrjälä <<a href="mailto:ville.syrjala@linux.intel.com">ville.syrjala@linux.intel.com</a>>
> > > Date: Fri Nov 21 21:00:36 2014 +0200
> > >
> > > drm/i915: Don't clobber crtc->new_config when nothing changes
> > >
> > > Is there an actual failure that affects the user?
> >
> > Hello Ville,
> >
> > I tested your patch: "commit 2d3d111a8f34606469e589d3491c9a64f62310b8",
> > With this commit + V47 BIOS+ BSW B1 CPU+ FAB2 board,
> > I can continually execute S3 command more than 5 cycles, feedback
> > i915_pm_resume_early message.-----------attach dmesg log:
> > ww39.2_patch_s3_dmesg.log
> >
> > While double-check with kernel: tag drm-intel-nightly 2014-11-21, I only can
> > do S3 2 or 3 times, then IP address unavailable, S3 command fail to execute
> > with "resource temporary unavailable" message.
> > attach two dmesg log: WW39.2_v47_s3_3rd_Resume_dmesg1.log,
> > WW39.2_v47_s3_2nd_Resume_dmesg2.log
>
> Are you saying 2d3d111a8f34606469e589d3491c9a64f62310b8 actually fixes
> something (apart from just silencing the WARN)? Because that would b a bit
> surprising.</span >
At least commit 2d3d111a8f34606469e589d3491c9a64f62310b8 can help us do more
cycles S3, and would you pls check does below call trace matter anything which
was got from the commit 2d3d111a8f34606469e589d3491c9a64f62310b8
[ 227.642868] ------------[ cut here ]------------
[ 227.642898] WARNING: CPU: 1 PID: 24 at drivers/gpu/drm/i915/i915_drv.c:1185
vlv_force_gfx_clock+0x41/0x1eb [i915]()
[ 227.642901] WARN_ON(!!(val & VLV_GFX_CLK_FORCE_ON_BIT) == force_on)
[ 227.642932] Modules linked in: dm_mod snd_hda_codec_hdmi
snd_hda_codec_realtek iTCO_wdt iTCO_vendor_support snd_hda_codec_generic
serio_raw pcspkr snd_hda_intel snd_hda_controller i2c_i801 lpc_ich mfd_core
snd_hda_codec snd_hwdep snd_pcm snd_timer snd soundcore option usb_wwan
usbserial battery ac acpi_cpufreq i915 button video drm_kms_helper drm
cfbfillrect cfbimgblt cfbcopyarea
[ 227.642937] CPU: 1 PID: 24 Comm: kworker/u8:1 Tainted: G W
3.18.0-rc5_kcloud_2d3d11_20141202+ #40
[ 227.642947] Workqueue: events_unbound async_run_entry_fn
[ 227.642954] 0000000000000000 0000000000000009 ffffffff817788a0
ffff88017a467c98
[ 227.642958] ffffffff81036742 ffff88017a467c90 ffffffffa007ea40
ffff88017a464000
[ 227.642962] ffff880175540000 0000000000000000 ffff88017a45a000
00000000ffffff92
[ 227.642964] Call Trace:
[ 227.642975] [<ffffffff817788a0>] ? dump_stack+0x41/0x51
[ 227.642981] [<ffffffff81036742>] ? warn_slowpath_common+0x78/0x90
[ 227.643008] [<ffffffffa007ea40>] ? vlv_force_gfx_clock+0x41/0x1eb [i915]
[ 227.643013] [<ffffffff8103679f>] ? warn_slowpath_fmt+0x45/0x4a
[ 227.643040] [<ffffffffa007ea40>] ? vlv_force_gfx_clock+0x41/0x1eb [i915]
[ 227.643067] [<ffffffffa007f9ea>] ? vlv_resume_prepare+0x511/0x546 [i915]
[ 227.643095] [<ffffffffa007fad8>] ? i915_resume_legacy+0x23/0x23 [i915]
[ 227.643121] [<ffffffffa007fa59>] ? i915_drm_resume_early+0x3a/0x96 [i915]
[ 227.643128] [<ffffffff813dd359>] ? dpm_run_callback+0x3a/0xc5
[ 227.643132] [<ffffffff813dd6b5>] ? device_resume_early+0x130/0x171
[ 227.643135] [<ffffffff813dd70a>] ? async_resume_early+0x14/0x38
[ 227.643140] [<ffffffff8104cfd7>] ? async_run_entry_fn+0x2d/0xbf
[ 227.643146] [<ffffffff810473f9>] ? process_one_work+0x1b3/0x316
[ 227.643149] [<ffffffff81047da1>] ? worker_thread+0x27d/0x369
[ 227.643153] [<ffffffff81047b24>] ? rescuer_thread+0x219/0x219
[ 227.643158] [<ffffffff8104b375>] ? kthread+0xce/0xd6
[ 227.643162] [<ffffffff8104b2a7>] ? kthread_create_on_node+0x162/0x162
[ 227.643167] [<ffffffff8177de2c>] ? ret_from_fork+0x7c/0xb0
[ 227.643171] [<ffffffff8104b2a7>] ? kthread_create_on_node+0x162/0x162
[ 227.643175] ---[ end trace cdf87c7c71c9a1bc ]---
Then test with kernel tag: drm-intel-testing 2014-11-21 we got this call trace:
any wrong here with i915? Would you give some comments, thanks a lot.
[ 417.963721] ------------[ cut here ]------------
[ 417.963782] WARNING: CPU: 1 PID: 4708 at
drivers/gpu/drm/i915/intel_display.c:10336 __intel_set_mode+0x95a/0x99a
[i915]()
[ 417.963961] WARN_ON(intel_crtc->new_config && intel_crtc->new_config !=
&intel_crtc->config)
[ 417.964024] Modules linked in: dm_mod iTCO_wdt iTCO_vendor_support
snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic serio_raw
snd_hda_intel snd_hda_controller option pcspkr usb_wwan snd_hda_codec snd_hwdep
usbserial snd_pcm snd_timer lpc_ich i2c_i801 snd mfd_core soundcore battery ac
acpi_cpufreq i915 button video drm_kms_helper drm cfbfillrect cfbimgblt
cfbcopyarea
[ 417.964032] CPU: 1 PID: 4708 Comm: kworker/u8:38 Tainted: G W
3.18.0-rc5_drm-intel-testing_167896_20141122_+ #117
[ 417.964054] Workqueue: events_unbound async_run_entry_fn
[ 417.964064] 0000000000000009 ffff880175f879b8 ffffffff8183b528
ffffffff81070ea5
[ 417.964073] ffff880175f87a08 ffff880175f879f8 ffffffff8103bba8
0000000000000000
[ 417.964081] ffffffffa00ea69f ffff880179ece000 ffff880179ece6f0
ffff88017a460000
[ 417.964084] Call Trace:
[ 417.964095] [<ffffffff8183b528>] dump_stack+0x46/0x58
[ 417.964102] [<ffffffff81070ea5>] ? up+0x39/0x40
[ 417.964110] [<ffffffff8103bba8>] warn_slowpath_common+0x81/0x9b
[ 417.964169] [<ffffffffa00ea69f>] ? __intel_set_mode+0x95a/0x99a [i915]
[ 417.964178] [<ffffffff8103bc65>] warn_slowpath_fmt+0x46/0x48
[ 417.964237] [<ffffffffa00ea69f>] __intel_set_mode+0x95a/0x99a [i915]
[ 417.964291] [<ffffffffa00eefe7>] intel_set_mode+0xa4/0xc5 [i915]
[ 417.964354] [<ffffffffa00f0cfe>] intel_modeset_setup_hw_state+0x991/0xa68
[i915]
[ 417.964402] [<ffffffffa00d5aaa>] ? chv_write64+0x26a/0x26a [i915]
[ 417.964436] [<ffffffffa0094206>] i915_drm_resume+0x108/0x176 [i915]
[ 417.964469] [<ffffffffa0094294>] i915_pm_resume+0x20/0x22 [i915]
[ 417.964478] [<ffffffff813bd719>] pci_pm_resume+0x70/0x85
[ 417.964483] [<ffffffff813bd6a9>] ? pci_pm_restore+0x9e/0x9e
[ 417.964491] [<ffffffff81456ae9>] dpm_run_callback+0x6c/0xf3
[ 417.964497] [<ffffffff81456eef>] device_resume+0x189/0x1cb
[ 417.964502] [<ffffffff81456f4f>] async_resume+0x1e/0x45
[ 417.964509] [<ffffffff81056923>] async_run_entry_fn+0x39/0xc6
[ 417.964518] [<ffffffff8104ff3c>] process_one_work+0x22b/0x409
[ 417.964524] [<ffffffff8104fea4>] ? process_one_work+0x193/0x409
[ 417.964532] [<ffffffff810503ad>] worker_thread+0x264/0x363
[ 417.964538] [<ffffffff81050149>] ? process_scheduled_works+0x2f/0x2f
[ 417.964545] [<ffffffff810545be>] kthread+0xed/0xf5
[ 417.964552] [<ffffffff810544d1>] ? __init_kthread_worker+0x5a/0x5a
[ 417.964560] [<ffffffff81842b6c>] ret_from_fork+0x7c/0xb0
[ 417.964566] [<ffffffff810544d1>] ? __init_kthread_worker+0x5a/0x5a
[ 417.964571] ---[ end trace 949003bc96008731 ]---</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>