<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:li.l.xu@intel.com" title="Li Xu <li.l.xu@intel.com>"> <span class="fn">Li Xu</span></a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [ALL 3.18 Bisected] DVI --rotation inverted can't invert normally"
href="https://bugs.freedesktop.org/show_bug.cgi?id=87662">bug 87662</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Keywords</td>
<td>bisect_pending
</td>
<td>
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>REOPENED
</td>
<td>ASSIGNED
</td>
</tr>
<tr>
<td style="text-align:right;">Summary</td>
<td>[ALL 3.18 Regression] DVI --rotation inverted can't invert normally
</td>
<td>[ALL 3.18 Bisected] DVI --rotation inverted can't invert normally
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [ALL 3.18 Bisected] DVI --rotation inverted can't invert normally"
href="https://bugs.freedesktop.org/show_bug.cgi?id=87662#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [ALL 3.18 Bisected] DVI --rotation inverted can't invert normally"
href="https://bugs.freedesktop.org/show_bug.cgi?id=87662">bug 87662</a>
from <span class="vcard"><a class="email" href="mailto:li.l.xu@intel.com" title="Li Xu <li.l.xu@intel.com>"> <span class="fn">Li Xu</span></a>
</span></b>
<pre>48404c1e53d4e15d7e3e77cd2c8f3f22973ef38e is the first bad commit
commit 48404c1e53d4e15d7e3e77cd2c8f3f22973ef38e
Author: Sonika Jindal <<a href="mailto:sonika.jindal@intel.com">sonika.jindal@intel.com</a>>
Date: Fri Aug 22 14:06:04 2014 +0530
drm/i915: Add 180 degree primary plane rotation support
Primary planes support 180 degree rotation. Expose the feature
through rotation drm property.
v2: Calculating linear/tiled offsets based on pipe source width and
height. Added 180 degree rotation support in ironlake_update_plane.
v3: Checking if CRTC is active before issueing update_plane. Added
wait for vblank to make sure we dont overtake page flips. Disabling
FBC since it does not work with rotated planes.
v4: Updated rotation checks for pending flips, fbc disable. Creating
rotation property only for Gen4 onwards. Property resetting as part
of lastclose.
v5: Resetting property in i915_driver_lastclose properly for planes
and crtcs. Fixed linear offset calculation that was off by 1 w.r.t
width in i9xx_update_plane and ironlake_update_plane. Removed tab
based indentation and unnecessary braces in intel_crtc_set_property
and intel_update_fbc. FBC and flip related checks should be done only
for valid crtcs.
v6: Minor nits in FBC disable checks for comments in
intel_crtc_set_property
and positioning the disable code in intel_update_fbc.
v7: In case rotation property on inactive crtc is updated, we return
successfully printing debug log as crtc is inactive and only property
change
is preserved.
v8: update_plane is changed to update_primary_plane, crtc->fb is changed to
crtc->primary->fb and return value of update_primary_plane is ignored.
v9: added rotation property to primary plane instead of crtc. Removing
reset
of rotation property from lastclose. rotation_property is moved to
drm_mode_config, so drm layer will take care of resetting. Adding updation
of
fbc when rotation is set to 0. Allowing rotation only if value is
different than old one.
v10: Calling intel_primary_plane_setplane instead of update_primary_plane
in
set_property(Daniel).
v11: Using same set_property function for both primary and sprite, Adding
primary plane specific code in the same function (Matt).
v12: Removing disabling/ enabling of fbc from set_property because it is
done
from intel_pipe_set_base. Other formatting
v13: we need to call disable_fbc before changing the rotation to 180,
disable_fbc from intel_pipe_set_base gets called very late, that will
be used to re-enable fbc if rotation is set to 0 (Ville).
Testcase: igt/kms_rotation_crc
Signed-off-by: Uma Shankar <<a href="mailto:uma.shankar@intel.com">uma.shankar@intel.com</a>>
Signed-off-by: Sagar Kamble <<a href="mailto:sagar.a.kamble@intel.com">sagar.a.kamble@intel.com</a>>
Signed-off-by: Sonika Jindal <<a href="mailto:sonika.jindal@intel.com">sonika.jindal@intel.com</a>>
[danvet: Add FIXME to explain why we need the open-coded update_fbc
hunk to disable fbc when rotated 180 degree. And make checkpatch
happier.]
Acked-by: Matt Roper <<a href="mailto:matthew.d.roper@intel.com">matthew.d.roper@intel.com</a>>
Signed-off-by: Daniel Vetter <<a href="mailto:daniel.vetter@ffwll.ch">daniel.vetter@ffwll.ch</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>