<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [PNV Bisected]igt/gem_exec_big fails"
href="https://bugs.freedesktop.org/show_bug.cgi?id=88191#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [PNV Bisected]igt/gem_exec_big fails"
href="https://bugs.freedesktop.org/show_bug.cgi?id=88191">bug 88191</a>
from <span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span></b>
<pre>Oh, and while I remember. The bug is clearly independent of 43566dedd, but
because of the mb() inside set-to-gtt-domain we conveniently masked this bug
i.e. the impact of the bug is non-existent, though it is probably the real
reason why I had to add the mb() there in the first place. That's for a latter
patch.
Oh, indeedy....
commit 63256ec5347fb2344a42adbae732b90603c92f35
Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
Date: Tue Jan 4 18:42:07 2011 +0000
drm/i915: Enforce write ordering through the GTT
We need to ensure that writes through the GTT land before any
modification to the MMIO registers and so must impose a mandatory write
barrier when flushing the GTT domain. This was revealed by relaxing the
write ordering by experimentally mapping the registers and the GATT as
write-combining.
commit d0a57789d5ec807fc218151b2fb2de4da30fbef5
Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
Date: Tue Oct 9 19:24:37 2012 +0100
drm/i915: Only insert the mb() before updating the fence parameter
With a fence, we only need to insert a memory barrier around the actual
fence alteration for CPU accesses through the GTT. Performing the
barrier in flush-fence was inserting unnecessary and expensive barriers
for never fenced objects.
Note removing the barriers from flush-fence, which was effectively a
barrier before every direct access through the GTT, revealed that we
where missing a barrier before the first access through the GTT. Lack of
that barrier was sufficient to cause GPU hangs.
Bingo.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>