<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - [ivb efi] Switching from efifb to i915.ko causes a hard hang with fbcon=vc:2-6"
href="https://bugs.freedesktop.org/show_bug.cgi?id=72765#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - [ivb efi] Switching from efifb to i915.ko causes a hard hang with fbcon=vc:2-6"
href="https://bugs.freedesktop.org/show_bug.cgi?id=72765">bug 72765</a>
from <span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span></b>
<pre>Code review says it is still buggy, e.g.:
diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index ea437245562e..90979e32bf4a 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -368,7 +368,7 @@ static void fbcon_update_softback(struct vc_data *vc)
static void fb_flashcursor(struct work_struct *work)
{
struct fb_info *info = container_of(work, struct fb_info, queue);
- struct fbcon_ops *ops = info->fbcon_par;
+ struct fbcon_ops *ops;
struct vc_data *vc = NULL;
int c;
int mode;
@@ -381,6 +381,7 @@ static void fb_flashcursor(struct work_struct *work)
if (ret == 0)
return;
+ ops = info->fbcon_par;
if (ops && ops->currcon != -1)
vc = vc_cons[ops->currcon].d;
has a similar unbind race as the original bug.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>