<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:jbarnes@virtuousgeek.org" title="Jesse Barnes <jbarnes@virtuousgeek.org>"> <span class="fn">Jesse Barnes</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [SKL]Time out and system reboot fails while running IGT cases: gem_ringfill/render, gem_ringfill/render-interruptible"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89001">bug 89001</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>michel.thierry@intel.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SKL]Time out and system reboot fails while running IGT cases: gem_ringfill/render, gem_ringfill/render-interruptible"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89001#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SKL]Time out and system reboot fails while running IGT cases: gem_ringfill/render, gem_ringfill/render-interruptible"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89001">bug 89001</a>
from <span class="vcard"><a class="email" href="mailto:jbarnes@virtuousgeek.org" title="Jesse Barnes <jbarnes@virtuousgeek.org>"> <span class="fn">Jesse Barnes</span></a>
</span></b>
<pre>Michel, have you seen this one? It's hard to capture logs since the system
hangs pretty hard, but I saw one that was a bad io access in the iowrite32 in
intel_logical_ring_emit() which sent me searching for our virtual_start mapping
setup. That led me to something like this:
diff --git a/drivers/gpu/drm/i915/intel_lrc.c
b/drivers/gpu/drm/i915/intel_lrc.c
index fcb074b..bc97457 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -504,8 +504,11 @@ static int execlists_context_queue(struct intel_engine_cs
*
unsigned long flags;
int num_elements = 0;
- if (to != ring->default_context)
- intel_lr_context_pin(ring, to);
+ if (to != ring->default_context) {
+ ret = intel_lr_context_pin(ring, to);
+ if (ret)
+ return ret;
+ }
if (!request) {
/*
@@ -802,13 +805,16 @@ intel_logical_ring_advance_and_submit(struct
intel_ringbuf
struct drm_i915_gem_request *request)
{
struct intel_engine_cs *ring = ringbuf->ring;
+ int ret;
intel_logical_ring_advance(ringbuf);
if (intel_ring_stopped(ring))
return;
- execlists_context_queue(ring, ctx, ringbuf->tail, request);
+ ret = execlists_context_queue(ring, ctx, ringbuf->tail, request);
+ if (ret)
+ DRM_ERROR("execlist context queue failed: %d\n", ret);
}
static int intel_lr_context_pin(struct intel_engine_cs *ring,
but that's not sufficient to fix this bug. It does seem important that we
check these return values though.
And this failure may indicate something wrong with the lrc handling code, I'm
not sure. Some additional, custom kernel debug code would probably help narrow
things down.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>