<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [SKL]igt/pm_rps/blocking fail" href="https://bugs.freedesktop.org/show_bug.cgi?id=89123#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [SKL]igt/pm_rps/blocking fail" href="https://bugs.freedesktop.org/show_bug.cgi?id=89123">bug 89123</a> from <a class="email" href="mailto:jbarnes@virtuousgeek.org" title="Jesse Barnes <jbarnes@virtuousgeek.org>"> Jesse Barnes</a> <pre>This test passes if run individually, but fails if min-max-config-idle is run first within the test. Akash, can you take a look? Maybe the turbo params are different enough on SKL that we need to adjust the tests. I had to apply this kernel patch as a starting point: diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 288c9d2..3fe2164 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -6696,7 +6696,8 @@ static int chv_freq_opcode(struct drm_i915_private *dev_pr int intel_gpu_freq(struct drm_i915_private *dev_priv, int val) { if (IS_GEN9(dev_priv->dev)) - return (val * GT_FREQUENCY_MULTIPLIER) / GEN9_FREQ_SCALER; + return DIV_ROUND_CLOSEST(val * GT_FREQUENCY_MULTIPLIER, + GEN9_FREQ_SCALER); else if (IS_CHERRYVIEW(dev_priv->dev)) return chv_gpu_freq(dev_priv, val); else if (IS_VALLEYVIEW(dev_priv->dev)) @@ -6708,7 +6709,8 @@ int intel_gpu_freq(struct drm_i915_private *dev_priv, int int intel_freq_opcode(struct drm_i915_private *dev_priv, int val) { if (IS_GEN9(dev_priv->dev)) - return (val * GEN9_FREQ_SCALER) / GT_FREQUENCY_MULTIPLIER; + return DIV_ROUND_CLOSEST(val * GEN9_FREQ_SCALER, + GT_FREQUENCY_MULTIPLIER); else if (IS_CHERRYVIEW(dev_priv->dev)) return chv_freq_opcode(dev_priv, val);</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>