<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [SNB+ Regression bisected]igt/pm_rpm/universal-planes cause call trace" href="https://bugs.freedesktop.org/show_bug.cgi?id=89550#c10">Comment # 10</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [SNB+ Regression bisected]igt/pm_rpm/universal-planes cause call trace" href="https://bugs.freedesktop.org/show_bug.cgi?id=89550">bug 89550</a> from <a class="email" href="mailto:hengx.ding@intel.com" title="Ding Heng <hengx.ding@intel.com>"> Ding Heng</a> <pre>2fdd7def16dd7580f297827930126c16b152ec11 is the first bad commit commit 2fdd7def16dd7580f297827930126c16b152ec11 Author: Matt Roper <<a href="mailto:matthew.d.roper@intel.com">matthew.d.roper@intel.com</a>> Date: Wed Mar 4 10:49:04 2015 -0800 drm/i915: Don't clobber plane state on internal disables We need to disable all sprite planes when disabling the CRTC. We had been using the top-level atomic 'disable' entrypoint to accomplish this, which was wrong. Not only can this lead to various locking issues, it also modifies the actual plane state, making it impossible to restore the plane properly later. For example, a DPMS off followed by a DPMS on will result in any sprite planes in use not being restored properly. The proper solution here is to call directly into our 'commit plane' hook with a copy of the plane's current state that has 'visible' set to false. Committing this dummy state will turn off the plane, but will not touch the actual plane->state pointer, allowing us to properly restore the plane state later. Signed-off-by: Matt Roper <<a href="mailto:matthew.d.roper@intel.com">matthew.d.roper@intel.com</a>> Signed-off-by: Daniel Vetter <<a href="mailto:daniel.vetter@ffwll.ch">daniel.vetter@ffwll.ch</a>> :040000 040000 fc36308f0bd42314b67ba401f783e47baaa9d06b 437fc3efb5aa5d569bf3bda658284125724b0d24 M drivers</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>