<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [ilk] IPS frequently downclocks the GPU when playing quakelive" href="https://bugs.freedesktop.org/show_bug.cgi?id=90137#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [ilk] IPS frequently downclocks the GPU when playing quakelive" href="https://bugs.freedesktop.org/show_bug.cgi?id=90137">bug 90137</a> from <a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> Chris Wilson</a> <pre>The IPS values are not documented as they were considered to be highly proprietary information by the hardware designers. Hmm, I missed the tracepoint. Can you apply: diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index d4d8305c73f5..f84b33bfb724 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -3736,6 +3736,9 @@ static bool __ironlake_set_rps(struct drm_i915_private *dev_priv, u8 val) if (WARN_ON(val > dev_priv->rps.max_freq)) return false; + if (val == dev_priv->rps.cur_freq) + return true; + assert_spin_locked(&mchdev_lock); if (wait_for_atomic((I915_READ(MEMSWCTL) & MEMCTL_CMD_STS) == 0, 10)) { @@ -3744,6 +3747,8 @@ static bool __ironlake_set_rps(struct drm_i915_private *dev_priv, u8 val) } dev_priv->rps.cur_freq = val; + trace_intel_gpu_freq_change(val); or just add a printk there. If you could review the freq<->delay conversion in the patch, I would be grateful - as that is where the bug most likely lies. We think in frequency for setting the RPS, but the hw talks delays.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>