<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - [snb] backlight issue on TOSHIBA PORTEGE R830 after suspend/resume" href="https://bugs.freedesktop.org/show_bug.cgi?id=82634#c19">Comment # 19</a> on <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - [snb] backlight issue on TOSHIBA PORTEGE R830 after suspend/resume" href="https://bugs.freedesktop.org/show_bug.cgi?id=82634">bug 82634</a> from <a class="email" href="mailto:jwrdegoede@fedoraproject.org" title="Hans de Goede <jwrdegoede@fedoraproject.org>"> Hans de Goede</a> <pre>Hi Jani, (In reply to Jani Nikula from <a href="show_bug.cgi?id=82634#c18">comment #18</a>) > (In reply to Hans de Goede from <a href="show_bug.cgi?id=82634#c17">comment #17</a>) > > Created <a href="attachment.cgi?id=116122" name="attach_116122" title="[PATCH] drm: i915: Add an enable_backlight_control module parameter">attachment 116122</a> <a href="attachment.cgi?id=116122&action=edit" title="[PATCH] drm: i915: Add an enable_backlight_control module parameter">[details]</a> <a href='page.cgi?id=splinter.html&bug=82634&attachment=116122'>[review]</a> [review] [review] > > [PATCH] drm: i915: Add an enable_backlight_control module parameter > > Hans, while I truly appreciate your efforts in fixing backlight issues, I > really *really* would like to exhaust all other options before adding such > module parameters. It should be made to Just Work(tm). I understand and I agree, but it seems that there just is not enough manpower to look into backlight breaking on (somewhat) older machines such as this one. The reporter has attached register dumps of the i915 both before and after suspend / resume and no one seems to have seriously looked into these... Also having 2 pieces of code (the i915 driver and the firmware) poling at the same registers during suspend / resume is just wrong, that it happens to often work does not make it less wrong, we really should always be loading either the i915 or the acpi-video backlight driver and not both. > All the cargo culting forum posts telling people to tweak their i915 module > parameters are giving us headaches. We've even made some of our module > parameters taint the kernel, and we won't look at bugs if people changed > them from their platform specific defaults. Just wanted to let you know my > opinion right from the start. Note that my plan (if this helps) includes a follow up patch which allows getting the same result via a quirk and then to add a quirk for this (and likely also some other Toshiba models). So things will just work, and we won't have people referencing ancient ubuntu form posts and taking dark magic settings from there to make things work. Regards, Hans</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>