<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [ivb] bright pixels appear when mousing over LibreOffice Impress" href="https://bugs.freedesktop.org/show_bug.cgi?id=91153#c21">Comment # 21</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [ivb] bright pixels appear when mousing over LibreOffice Impress" href="https://bugs.freedesktop.org/show_bug.cgi?id=91153">bug 91153</a> from <a class="email" href="mailto:joe@wildlava.com" title="Joe Peterson <joe@wildlava.com>"> Joe Peterson</a> <pre>Ok, according to my bisection (and I want to test the "good" version a little more before I declare it good), the following commit appears to "fix" it: e47eb0c sna: Don't unroll BLT points Looking at the diff for that commit, I do see something potentially suspect in the old code in the second unrolled block: - if (n_this_time & 4) { - *((uint64_t *)b + 0) = pt_add(cmd, p+0, dx, dy); - *((uint64_t *)b + 1) = pt_add(cmd, p+1, dx, dy); - *((uint64_t *)b + 2) = pt_add(cmd, p+2, dx, dy); - *((uint64_t *)b + 3) = pt_add(cmd, p+3, dx, dy); - b += 8; - p += 8; Note that both b and p are incremented by 8. In the previous block, which looks more correct they are: - if (n_this_time & 4) { - *((uint64_t *)b + 0) = pt_add(cmd, p+0, 0, 0); - *((uint64_t *)b + 1) = pt_add(cmd, p+1, 0, 0); - *((uint64_t *)b + 2) = pt_add(cmd, p+2, 0, 0); - *((uint64_t *)b + 3) = pt_add(cmd, p+3, 0, 0); - b += 8; - p += 4; I didn't analyze the unrolled code completely yet, but I wonder if that is where the bug was before the code was "rolled". I'll look at this a bit more later, but I wanted to get where I was so far to you now...</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>